Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum botocore version #1362

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jul 19, 2022

SUMMARY

Inline with the documented policy, bump botocore (and boto3/awscli) requirements for main branch

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

README.md
requirements.txt
tests/integration/constraints.txt
tests/unit/constraints.txt

ADDITIONAL INFORMATION
[✔ mchappel@mchappel botocore] $ git show 1.21.0
tag 1.21.0
Tagger: aws-sdk-python-automation <[email protected]>
Date:   Thu Jul 15 18:08:47 2021 +0000

Tagging 1.21.0 release.

See also ansible-collections/amazon.aws#934

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration needs_triage tests tests labels Jul 19, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 42s
✔️ build-ansible-collection SUCCESS in 5m 14s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 22s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 12m 17s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 02s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 19s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 03s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 40s
✔️ ansible-test-splitter SUCCESS in 2m 31s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jul 19, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 5m 26s
✔️ build-ansible-collection SUCCESS in 5m 04s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 03s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 05s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 25s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 03s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 56s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 59s
✔️ ansible-test-splitter SUCCESS in 2m 35s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 464c6ca into ansible-collections:main Jul 19, 2022
@tremble tremble deleted the botocore/1.21.0 branch September 9, 2022 09:02
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…scription. (ansible-collections#1362)

Corrected wrong parameter for SSH private key file. Improved value de…

The compose section for the Allowed Options in the Dynamic inventory plugin guide contains the wrong key ansible_private_ssh_key_file, it needs to be ansible_ssh_private_key_file.
SUMMARY
Minor documentation improvement, corrects wrong key for SSH private key file and adds better description for value.
Fixes ansible-collections#1361
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
aws_ec2_guide.rst
ADDITIONAL INFORMATION
fixes: ansible-collections#1361

Reviewed-by: Mark Chappell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) needs_triage tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants