[PR #1355/5f0e10e7 backport][stable-4] cloudwatchevent_rule - Add argspec validation for targets #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
cloudwatchevent_rule - Add argspec validation for targets SUMMARY fixes: #201 Targets currently has minimal validation applied. Because of the way Ansible converts JSON strings to dicts/lists, then back to the Python format string representing the dicts/lists, unless we explicitly define a parameter is a JSON string they get corrupted. This also moves the new input_paths_map/input_template parameters under input_transformer. Because we've not released 4.1.0 yet this doesn't cause any breakage. This will make adding other target parameters simpler further down the road. (There's a lot that we don't support today) ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudwatchevent_rule ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> (cherry picked from commit 5f0e10e)
tremble
approved these changes
Jul 15, 2022
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
bug
tremble
added
mergeit
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-4/5f0e10e7cac9a72e7938f277e362d50df7910923/pr-1355
branch
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
… hosts (ansible-collections#1359) ec2_metadata_facts - fix AttributeError when running on older managed hosts SUMMARY Unlike most of our modules, the ec2_metadata_facts is always expected to run on managed hosts, and doesn't depend on the AWS SDKs. With Python 2.7 support still in place for managed hosts on all supported Ansible versions it makes sense, in the specific case of ec2_metadata_facts, to continue to support Python 2.7 for now. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_metadata_facts ADDITIONAL INFORMATION fixes: ansible-collections#1358 Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1355 as merged into main (5f0e10e).
SUMMARY
fixes: #201
Targets currently has minimal validation applied.
Because of the way Ansible converts JSON strings to dicts/lists, then back to the Python format string representing the dicts/lists, unless we explicitly define a parameter is a JSON string they get corrupted.
This also moves the new input_paths_map/input_template parameters under input_transformer. Because we've not released 4.1.0 yet this doesn't cause any breakage. This will make adding other target parameters simpler further down the road. (There's a lot that we don't support today)
ISSUE TYPE
COMPONENT NAME
cloudwatchevent_rule
ADDITIONAL INFORMATION