Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_vpc_peer - Fix idempotency when accepter/requester is reversed #1346

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jul 11, 2022

SUMMARY

fixes: #580

Fixes a bug where a new peering request would be created when the accepter/requester is reversed

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/ec2_vpc_peer.py

ADDITIONAL INFORMATION

@tremble tremble added backport-3 PR should be backported to the stable-3 branch backport-4 PR should be backported to the stable-4 branch labels Jul 11, 2022
@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review has_issue integration tests/integration module module plugins plugin (any type) tests tests labels Jul 11, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 56s
✔️ build-ansible-collection SUCCESS in 5m 08s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 15s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 34s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 14m 25s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 16s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 07s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 55s
✔️ ansible-test-splitter SUCCESS in 3m 21s
✔️ integration-community.aws-1 SUCCESS in 6m 34s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jul 12, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 3m 49s
✔️ build-ansible-collection SUCCESS in 4m 55s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 37s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 12m 49s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 27s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 07s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 56s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 7m 22s
✔️ ansible-test-splitter SUCCESS in 2m 28s
✔️ integration-community.aws-1 SUCCESS in 6m 06s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 1c3ad28 into ansible-collections:main Jul 12, 2022
@patchback
Copy link

patchback bot commented Jul 12, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/1c3ad2817ea44cd77f8d84d7562db1feb2cdabe1/pr-1346

Backported as #1350

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 12, 2022
…1346)

ec2_vpc_peer - Fix idempotency when accepter/requester is reversed

SUMMARY
fixes: #580
Fixes a bug where a new peering request would be created when the accepter/requester is reversed
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
plugins/modules/ec2_vpc_peer.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 1c3ad28)
@patchback
Copy link

patchback bot commented Jul 12, 2022

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/1c3ad2817ea44cd77f8d84d7562db1feb2cdabe1/pr-1346

Backported as #1351

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 12, 2022
…1346)

ec2_vpc_peer - Fix idempotency when accepter/requester is reversed

SUMMARY
fixes: #580
Fixes a bug where a new peering request would be created when the accepter/requester is reversed
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
plugins/modules/ec2_vpc_peer.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 1c3ad28)
@github-actions
Copy link

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jul 12, 2022
…1346) (#1350)

[PR #1346/1c3ad281 backport][stable-3] ec2_vpc_peer - Fix idempotency when accepter/requester is reversed

This is a backport of PR #1346 as merged into main (1c3ad28).
SUMMARY
fixes: #580
Fixes a bug where a new peering request would be created when the accepter/requester is reversed
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
plugins/modules/ec2_vpc_peer.py
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jul 12, 2022
…1346) (#1351)

[PR #1346/1c3ad281 backport][stable-4] ec2_vpc_peer - Fix idempotency when accepter/requester is reversed

This is a backport of PR #1346 as merged into main (1c3ad28).
SUMMARY
fixes: #580
Fixes a bug where a new peering request would be created when the accepter/requester is reversed
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
plugins/modules/ec2_vpc_peer.py
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
@tremble tremble deleted the issues/580 branch September 9, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3 PR should be backported to the stable-3 branch backport-4 PR should be backported to the stable-4 branch bug This issue/PR relates to a bug community_review has_issue integration tests/integration mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ec2_vpc_peer creates new peering connection when Accepter and Requester are reversed
3 participants