kms_key - Finish deprecation of policy_grant_types and related keys #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
added
the
do_not_backport
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
tremble
requested review from
jatorcasso,
jillr,
alinabuzachis and
markuman
and removed request for
jatorcasso
markuman
approved these changes
Jul 11, 2022
alinabuzachis
approved these changes
Jul 11, 2022
1 task
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…nsible-collections#1344) kms_key - Finish deprecation of policy_grant_types and related keys SUMMARY Managing the KMS IAM Policy via policy_mode and policy_grant_types was fragile and previously deprecated. Complete the deprecation and remove the options in in favour of the policy option. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/kms_key.py ADDITIONAL INFORMATION Original deprecation: ansible/ansible#60561 Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@9fb435d
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
aws_collection_constants SUMMARY Adds a simple lookup plugin to retrieve some of the constants in the collection ISSUE TYPE New Module Pull Request COMPONENT NAME plugins/lookup/aws_collection_constants.py ADDITIONAL INFORMATION This means we've one less place we need to update when bumping the supported botocore version. Reviewed-by: Bikouo Aubin <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Managing the KMS IAM Policy via
policy_modeandpolicy_grant_typeswas fragile and previously deprecated.Complete the deprecation and remove the options in in favour of the
policyoption.ISSUE TYPE
COMPONENT NAME
plugins/modules/kms_key.py
ADDITIONAL INFORMATION
Original deprecation: ansible/ansible#60561