ecs_service - Minor fixups #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bad rebase resulted in a duplicated parameter - Fixup "changed" after adding initial support for tags
ansibullbot
added
community_review
feature
jatorcasso
approved these changes
Jul 9, 2022
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
markuman
pushed a commit
to markuman/community.aws
that referenced
this pull request
Aug 4, 2022
ecs_service - Minor fixups SUMMARY Bad rebase resulted in a duplicated parameter Fixup "changed" after adding initial support for tags ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION Bugs aren't in a released version yet, no need for changelog Reviewed-by: Joseph Torcasso <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Aug 4, 2022
backport-4: Minor fixups (#1328) forgotten backport-4 breaks ecs_service in 4.1.0 after it's merged, 4.1.1 must be released asap Traceback (most recent call last): File "/root/.ansible/tmp/ansible-tmp-1659604767.311191-146-86085088410654/AnsiballZ_ecs_service.py", line 102, in <module> _ansiballz_main() File "/root/.ansible/tmp/ansible-tmp-1659604767.311191-146-86085088410654/AnsiballZ_ecs_service.py", line 94, in _ansiballz_main invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS) File "/root/.ansible/tmp/ansible-tmp-1659604767.311191-146-86085088410654/AnsiballZ_ecs_service.py", line 40, in invoke_module runpy.run_module(mod_name='ansible_collections.community.aws.plugins.modules.ecs_service', init_globals=None, run_name='__main__', alter_sys=True) File "/usr/lib/python3.8/runpy.py", line 207, in run_module return _run_module_code(code, init_globals, run_name, mod_spec) File "/usr/lib/python3.8/runpy.py", line 97, in _run_module_code _run_code(code, mod_globals, init_globals, File "/usr/lib/python3.8/runpy.py", line 87, in _run_code exec(code, run_globals) File "/tmp/ansible_ecs_service_payload_jubeafm6/ansible_ecs_service_payload.zip/ansible_collections/community/aws/plugins/modules/ecs_service.py", line 1134, in <module> File "/tmp/ansible_ecs_service_payload_jubeafm6/ansible_ecs_service_payload.zip/ansible_collections/community/aws/plugins/modules/ecs_service.py", line 969, in main File "/tmp/ansible_ecs_service_payload_jubeafm6/ansible_ecs_service_payload.zip/ansible_collections/community/aws/plugins/modules/ecs_service.py", line 733, in is_matching_service KeyError: 'deploymentController' ecs_service - Minor fixups SUMMARY Bad rebase resulted in a duplicated parameter Fixup "changed" after adding initial support for tags ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION Bugs aren't in a released version yet, no need for changelog Reviewed-by: Joseph Torcasso SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
ec2_vpc_route_table - fix integration test after 1308 SUMMARY ansible-collections#1308 means query is no longer needed (and no longer supported) ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_route_table ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
ecs_service
ADDITIONAL INFORMATION
Bugs aren't in a released version yet, no need for changelog