[PR #518/b03919db backport][stable-4] glue_connection - Avoid converting connection_parameter keys to lowercase #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
…case (#518) glue_connection - Avoid converting connection_parameter keys to lowercase SUMMARY This is a follow to my own PR #503. This is a cosmetic change that prevents converting keys in connection_parameters dict to lowercase. ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_glue_connection ADDITIONAL INFORMATION As an example, this: - community.aws.glue_connection: name: test-connection connection_parameters: JDBC_ENFORCE_SSL: "false" ... is a valid value, while this: - community.aws.glue_connection: name: test-connection connection_parameters: jdbc_enforce_ssl: "false" ... is not. This PR simply aligns the module output to the expected input. Reviewed-by: Mark Chappell <None> (cherry picked from commit b03919d)
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
tremble
approved these changes
Jul 6, 2022
ansibullbot
added
bug
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-4/b03919db5233d682e2aafb957d9276b6d58b5881/pr-518
branch
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…e found (ansible-collections#1321) ec2_ami - allow ImageAvailable waiter to retry when the image can't be found SUMMARY When using the image_available waiter shortly after triggering the creation of an AMI this can fail (Amazon sometimes return from creation calls, with an ID, before the APIs recognise that the resource exists) Additionally splits up the AMI tests, it's sporadically timing out. (taking a snapshot of a running instance is slow) ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_ami ADDITIONAL INFORMATION https://e7359f847acd480e3075-df27b72133198827a14e5ee13616eeff.ssl.cf1.rackcdn.com/periodic/github.com/ansible-collections/amazon.aws/main/integration-amazon.aws-target-ec2_ami/adb87fd/job-output.txt Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Bulk update imports after reshuffle Depends-On: ansible-collections#1323 Depends-On: ansible-collections#1322 Depends-On: ansible-collections#1321 SUMMARY module_utils code got split up. Bulk update the imports to reflect this ISSUE TYPE Feature Pull Request COMPONENT NAME various ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #518 as merged into main (b03919d).
SUMMARY
This is a follow to my own PR #503.
This is a cosmetic change that prevents converting keys in connection_parameters dict to lowercase.
ISSUE TYPE
COMPONENT NAME
aws_glue_connection
ADDITIONAL INFORMATION
As an example, this:
is a valid value, while this:
is not.
This PR simply aligns the module output to the expected input.