Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cloudwatch metrics_alarm #1304

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jul 4, 2022

SUMMARY

In line with the new naming guidelines rename ec2_metric_alarm to cloudwatch_metric_alarm

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/cloudwatch_metric_alarm.py
plugins/modules/ec2_metric_alarm.py

ADDITIONAL INFORMATION

@tremble tremble requested a review from alinabuzachis July 4, 2022 13:17
@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review docs feature This issue/PR relates to a feature request integration tests/integration module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests labels Jul 4, 2022
@github-actions
Copy link

github-actions bot commented Jul 4, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 5m 12s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 22s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 26s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 28s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 09s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 19s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 7m 36s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 31s
✔️ ansible-test-splitter SUCCESS in 2m 37s
✔️ integration-community.aws-1 SUCCESS in 10m 07s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jul 4, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 31s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 08s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 20s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 12m 05s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 03s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 07s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 29s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 36s
✔️ ansible-test-splitter SUCCESS in 2m 32s
✔️ integration-community.aws-1 SUCCESS in 9m 00s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 88c62c5 into ansible-collections:main Jul 4, 2022
@tremble tremble deleted the renames/ec2_metric_alarm branch July 7, 2022 19:22
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
Rename cloudwatch metrics_alarm

SUMMARY
In line with the new naming guidelines rename ec2_metric_alarm to cloudwatch_metric_alarm
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/modules/cloudwatch_metric_alarm.py
plugins/modules/ec2_metric_alarm.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@88c62c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review docs feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants