Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable all sanity tests #129

Merged

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Right now, the pylint, validate-modules and ansible-doc sanity tests are not run in CI. This removes the expectation from tests/utils/shippable/sanity.sh that there are five sanity check groups so that all tests are run.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

CI

@felixfontein
Copy link
Contributor Author

Tests will probably look better once #128 is merged.

One problem (https://app.shippable.com/github/ansible-collections/community.aws/runs/374/1/tests) is that devel branch is now version 2.11, and this collection claims it requires Ansible < 2.11. I'm not sure how this is best fixed.

@felixfontein
Copy link
Contributor Author

restart tests

@felixfontein felixfontein reopened this Jul 8, 2020
@felixfontein
Copy link
Contributor Author

Ok, the only remaining problem is that the collection is not compatible with Ansible 2.11.

@jillr
Copy link
Collaborator

jillr commented Jul 8, 2020

thanks @felixfontein!

@jillr jillr merged commit f0e7d33 into ansible-collections:main Jul 8, 2020
@felixfontein felixfontein deleted the enable-all-sanity-tests branch July 9, 2020 05:43
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
* Enable all sanity tests.

* Update ignore.txt.

Co-authored-by: Jill R <[email protected]>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
* Enable all sanity tests.

* Update ignore.txt.

Co-authored-by: Jill R <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants