Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete iam_cert and rds_snapshot deprecations #1276

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 29, 2022

SUMMARY

Delayed from 4.0.0 to 5.0.0 remove the deprecated aliases

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

iam_server_certificate
rds_instance_snapshot

ADDITIONAL INFORMATION

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Jun 29, 2022
@github-actions
Copy link

github-actions bot commented Jun 29, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 02s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 46s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 27s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 47s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 20s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 21s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 41s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 44s
✔️ ansible-test-splitter SUCCESS in 2m 28s
✔️ integration-community.aws-1 SUCCESS in 6m 07s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

warning_text: >-
iam_cert has been renamed to iam_server_certificate for consistency.
Please update your tasks.
rds_snapshot:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have to also remove those from the action group?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this comment. Yes you're right, I missed that.

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 29, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 05s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 12s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 20s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 12s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 32s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 25s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 12s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 37s
✔️ ansible-test-splitter SUCCESS in 2m 39s
✔️ integration-community.aws-1 SUCCESS in 6m 12s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit d38a4b1 into ansible-collections:main Jun 29, 2022
@tremble tremble deleted the deprecation/5.0.0/aliases branch July 7, 2022 19:23
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…ts (ansible-collections#1276)

add .gitignore for inventory automatically created by integration tests

SUMMARY
Helps fix ansible-collections#924
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
tests
ADDITIONAL INFORMATION
When running integration tests, a file is generated at tests/integration/inventory. This file contains paths specific to the test machine. I assume this shouldn't be committed. So I've added a .gitignore for it.
The leading slash is to make it not apply recursively. (Stack Overflow)

Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…1276)

Complete iam_cert and rds_snapshot deprecations

SUMMARY
Delayed from 4.0.0 to 5.0.0 remove the deprecated aliases
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_server_certificate
rds_instance_snapshot
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@d38a4b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants