Re-enable and update integration tests for aws_ssm_parameter_store #1241

tremble · 2022-06-19T15:02:45Z

SUMMARY

Fixes exception when description was updated within passing value.
Rewrite and enable integration tests for module
Add some return values

While the integration tests don't include coverage for the more complex options for aws_ssm_parameter_store these have never existed. Having something enabled gives future module developers something to build upon.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

aws_ssm_parameter_store

ADDITIONAL INFORMATION

Exception:

TASK [aws_ssm_parameter_store : Update description] ****************************
task path: /root/ansible_collections/community/aws/tests/output/.tmp/integration/aws_ssm_parameter_store-071mpr89-ÅÑŚÌβŁÈ/tests/integration/targets/aws_ssm_parameter_store/tasks/main.yml:64
Using module file /root/ansible_collections/community/aws/plugins/modules/aws_ssm_parameter_store.py
Pipelining is enabled.
<testhost> ESTABLISH LOCAL CONNECTION FOR USER: root
<testhost> EXEC /bin/sh -c 'ANSIBLE_DEBUG_BOTOCORE_LOGS=True /usr/bin/python3.10 && sleep 0'
The full traceback is:
Traceback (most recent call last):
  File "/tmp/ansible_aws_ssm_parameter_store_payload_13s3_ao3/ansible_aws_ssm_parameter_store_payload.zip/ansible_collections/community/aws/plugins/modules/aws_ssm_parameter_store.py", line 160, in update_parameter
  File "/usr/local/lib/python3.10/dist-packages/botocore/client.py", line 357, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/usr/local/lib/python3.10/dist-packages/botocore/client.py", line 648, in _make_api_call
    request_dict = self._convert_to_request_dict(
  File "/usr/local/lib/python3.10/dist-packages/botocore/client.py", line 696, in _convert_to_request_dict
    request_dict = self._serializer.serialize_to_request(
  File "/usr/local/lib/python3.10/dist-packages/botocore/validate.py", line 293, in serialize_to_request
    raise ParamValidationError(report=report.generate_report())
botocore.exceptions.ParamValidationError: Parameter validation failed:
Invalid type for parameter Value, value: None, type: <class 'NoneType'>, valid types: <class 'str'>
fatal: [testhost]: FAILED! => {
    "boto3_version": "1.17.0",
    "botocore_version": "1.20.0",
    "changed": false,
    "invocation": {
        "module_args": {
            "aws_access_key": "ASIA6CCDWXDOM4BEFFL4",
            "aws_ca_bundle": null,
            "aws_config": null,
            "aws_secret_key": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "debug_botocore_endpoint_logs": true,
            "decryption": true,
            "description": "This is an updated example",
            "ec2_url": null,
            "key_id": "alias/aws/ssm",
            "name": "/ansible-test-12184966-mchappel/Simple",
            "overwrite_value": "changed",
            "profile": null,
            "region": "us-east-1",
            "security_token": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "state": "present",
            "string_type": "String",
            "tier": "Standard",
            "validate_certs": true,
            "value": null
        }
    },
    "msg": "setting parameter: Parameter validation failed:\nInvalid type for parameter Value, value: None, type: <class 'NoneType'>, valid types: <class 'str'>",
    "resource_actions": [
        "ssm:GetParameter"
    ]
}

ansibullbot · 2022-06-19T15:03:30Z

cc @116davinder @jillr @markuman @mikedlr @nathanwebsterdotme @ozbillwang @s-hertel
click here for bot help

tremble · 2022-06-20T08:05:45Z

Moving to WIP, something weird with idempotency when running in CI that I'm not hitting when I run it locally...

alinabuzachis · 2022-06-20T08:53:12Z

2022-06-20 07:02:24.736910 \| controller \| TASK [aws_ssm_parameter_store : Lookup a single key] ***************************
--
2671 | 2022-06-20 07:02:24.737004 \| controller \| task path: /home/zuul/.ansible/collections/ansible_collections/community/aws/tests/integration/targets/aws_ssm_parameter_store/tasks/main.yml:166
2672 | 2022-06-20 07:02:24.887246 \| controller \| AWS_ssm name lookup term: ['/ansible-test-63611552-node-0002705301/Simple']
2673 | 2022-06-20 07:02:25.324840 \| controller \| AWS_ssm path lookup returning: ['A simple VALue']
2674 | 2022-06-20 07:02:25.368591 \| controller \| ok: [testhost] => {
2675 | 2022-06-20 07:02:25.368606 \| controller \|     "ansible_facts": {
2676 | 2022-06-20 07:02:25.368609 \| controller \|         "lookup_value": "A simple VALue"
2677 | 2022-06-20 07:02:25.368616 \| controller \|     },
2678 | 2022-06-20 07:02:25.368621 \| controller \|     "changed": false
2679 | 2022-06-20 07:02:25.368624 \| controller \| }
2680 | 2022-06-20 07:02:25.412051 \| controller \|
2681 | 2022-06-20 07:02:25.412075 \| controller \| TASK [aws_ssm_parameter_store : assert] ****************************************
2682 | 2022-06-20 07:02:25.412149 \| controller \| task path: /home/zuul/.ansible/collections/ansible_collections/community/aws/tests/integration/targets/aws_ssm_parameter_store/tasks/main.yml:169
2683 | 2022-06-20 07:02:25.473091 \| controller \| fatal: [testhost]: FAILED! => {
2684 | 2022-06-20 07:02:25.473135 \| controller \|     "assertion": "result is not changed",
2685 | 2022-06-20 07:02:25.473144 \| controller \|     "changed": false,
2686 | 2022-06-20 07:02:25.473151 \| controller \|     "evaluated_to": false,
2687 | 2022-06-20 07:02:25.473158 \| controller \|     "msg": "Assertion failed"
2688 | 2022-06-20 07:02:25.473164 \| controller \| }

tremble · 2022-06-20T08:54:05Z

Yup, that's why I bumped it back to WIP

github-actions · 2022-06-20T11:05:22Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

softwarefactory-project-zuul · 2022-06-20T12:38:42Z

Build succeeded.

softwarefactory-project-zuul · 2022-06-21T13:23:54Z

Build succeeded (gate pipeline).

…ections#1241) ec2_security_group - fix bug in handling of `ports: -1` SUMMARY Before we defined a schema for rules YAML would guess that -1 was an integer. With ports is explicitly defined as a string it was trying to handle -1 as a range, rather than an integer ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_security_group ADDITIONAL INFORMATION Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: Mark Chappell <None>

ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Jun 19, 2022

tremble requested review from jatorcasso and alinabuzachis June 19, 2022 15:08

ansibullbot added python3 traceback labels Jun 19, 2022

This comment was marked as resolved.

Sign in to view

tremble force-pushed the tests/enable/aws_ssm_parameter_store branch from 3eb77d3 to 298341d Compare June 19, 2022 17:40

This comment was marked as resolved.

Sign in to view

tremble changed the title ~~Re-enable and update integration tests for aws_ssm_parameter_store~~ [WIP] Re-enable and update integration tests for aws_ssm_parameter_store Jun 20, 2022

ansibullbot added the WIP Work in progress label Jun 20, 2022

alinabuzachis approved these changes Jun 20, 2022

View reviewed changes

Re-enable and update integration tests for aws_ssm_parameter_store

78dff53

tremble force-pushed the tests/enable/aws_ssm_parameter_store branch from 2dec678 to fc74182 Compare June 20, 2022 10:59

This comment was marked as resolved.

Sign in to view

tremble force-pushed the tests/enable/aws_ssm_parameter_store branch from fc74182 to 4950fba Compare June 20, 2022 11:30

tremble changed the title ~~[WIP] Re-enable and update integration tests for aws_ssm_parameter_store~~ Re-enable and update integration tests for aws_ssm_parameter_store Jun 20, 2022

This comment was marked as resolved.

Sign in to view

ansibullbot removed the WIP Work in progress label Jun 20, 2022

Add parameter_metadata to return values

be3c320

tremble force-pushed the tests/enable/aws_ssm_parameter_store branch from 4950fba to be3c320 Compare June 20, 2022 12:21

tremble requested a review from alinabuzachis June 20, 2022 12:39

alinabuzachis approved these changes Jun 21, 2022

View reviewed changes

tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 21, 2022

softwarefactory-project-zuul bot merged commit c5034b2 into ansible-collections:main Jun 21, 2022

renovate bot mentioned this pull request Jun 24, 2022

chore(deps): update dependency community.aws to v4 linxside/ansible-ee#34

Merged

1 task

tremble deleted the tests/enable/aws_ssm_parameter_store branch July 7, 2022 19:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Re-enable and update integration tests for aws_ssm_parameter_store #1241

Re-enable and update integration tests for aws_ssm_parameter_store #1241

tremble commented Jun 19, 2022 •

edited

Loading

ansibullbot commented Jun 19, 2022

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

tremble commented Jun 20, 2022

alinabuzachis commented Jun 20, 2022

tremble commented Jun 20, 2022

github-actions bot commented Jun 20, 2022 •

edited

Loading

This comment was marked as resolved.

This comment was marked as resolved.

softwarefactory-project-zuul bot commented Jun 20, 2022

softwarefactory-project-zuul bot commented Jun 21, 2022

Re-enable and update integration tests for aws_ssm_parameter_store #1241

Re-enable and update integration tests for aws_ssm_parameter_store #1241

Conversation

tremble commented Jun 19, 2022 • edited Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibullbot commented Jun 19, 2022

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

tremble commented Jun 20, 2022

alinabuzachis commented Jun 20, 2022

tremble commented Jun 20, 2022

github-actions bot commented Jun 20, 2022 • edited Loading

Docs Build 📝

This comment was marked as resolved.

This comment was marked as resolved.

softwarefactory-project-zuul bot commented Jun 20, 2022

softwarefactory-project-zuul bot commented Jun 21, 2022

tremble commented Jun 19, 2022 •

edited

Loading

github-actions bot commented Jun 20, 2022 •

edited

Loading