[PR #1221/20f2afd7 backport][stable-3] aws_codebuild - Add resource_tags parameter and deprecate tags #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
aws_codebuild - Add resource_tags parameter and deprecate tags SUMMARY aws_codebuild currently uses the boto3 style 'list of dictionaries' format rather than the usual dictionary format. Add a resource_tags parameter that accepts the usual dictionary format Add the purge_tags parameter deprecate the tags parameter in preparation for switching it to the usual dict format expand integration tests for tags and description make source and artifacts optional unless creating a new project fix bug with inconsistent "changed" state due to tag order not being guaranteed ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME aws_codebuild ADDITIONAL INFORMATION The (boto3) tags format in the return value when describing a project makes no guarantees about the order it'll return the key/value pairs. As such, when multiple tags were set the naïve original == new comparison would sporadically return "changed" when no change had occurred. Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None> (cherry picked from commit 20f2afd)
ansibullbot
added
bug
alinabuzachis
approved these changes
Jun 7, 2022
it's just introduce a deprecation. No breaking change. I'm fine with that. Users should be informed as early as possible. |
| different formats. | ||
| returned: when configured | ||
| type: dict | ||
| version_added: 4.0.0 |
There was a problem hiding this comment.
I'll update that and backport if/when this is merged.
markuman
added
mergeit
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-3/20f2afd75e506d90a72fb27e4cba3bb09f707494/pr-1221
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1221 as merged into main (20f2afd).
SUMMARY
aws_codebuild currently uses the boto3 style 'list of dictionaries' format rather than the usual dictionary format.
resource_tagsparameter that accepts the usual dictionary formatpurge_tagsparametertagsparameter in preparation for switching it to the usual dict formatsourceandartifactsoptional unless creating a new projectISSUE TYPE
COMPONENT NAME
aws_codebuild
ADDITIONAL INFORMATION
The (boto3)
tagsformat in the return value when describing a project makes no guarantees about the order it'll return the key/value pairs. As such, when multiple tags were set the naïveoriginal == newcomparison would sporadically return "changed" when no change had occurred.