lambda - Add support for purge_tags #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
jatorcasso
reviewed
Jun 2, 2022
| # We're done | ||
| module.exit_json(changed=changed, **camel_dict_to_snake_dict(response)) | ||
| module.exit_json(changed=changed, **response) |
There was a problem hiding this comment.
Can we axe the format_response method by using ignore_list for the tags?
Suggested change
| module.exit_json(changed=changed, **response) | |
| module.exit_json(changed=changed, **camel_dict_to_snake_dict(response, ignore_list=['Tags']) |
There was a problem hiding this comment.
In theory, yes.
However, I prefer splitting it out because we have two places where we're making the same transformation. By turning it into a function we reduce the chance of introducing inconsistent behaviour in a future change.
For example: When making this change I initially missed that this transformation was happening in two different spots!
jatorcasso
approved these changes
Jun 2, 2022
1 task
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
lambda - Add support for purge_tags
SUMMARY
Use tagging fragment
Add purge_tags
Add resource_tags alias to tags
fix bug with returned tag names getting snake cased
fix bug where the lambda module was modifying tags in check mode
Tweak tagging to require an explicit tags: {} to remove tags
ISSUE TYPE
Bugfix Pull Request
Docs Pull Request
Feature Pull Request
COMPONENT NAME
lambda
ADDITIONAL INFORMATION
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Mark Chappell <None>
This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@982580a
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
add pytest-forked to test requirements SUMMARY ansible-test is using pytest --forked we need the sub-module installed ISSUE TYPE Bugfix Pull Request COMPONENT NAME test-requirements.txt ADDITIONAL INFORMATION See also: ansible/ansible#76679 Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…s#1199) ec2_instance - validate options on tower_callback Depends-On: ansible-collections#1202 SUMMARY Validate options for tower_callback parameter Set tower_callback.set_password (the password) to no_log=True ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
tags: {}to remove tagsISSUE TYPE
COMPONENT NAME
lambda
ADDITIONAL INFORMATION