[PR #1152/0c76aedd backport][stable-3] lambda_info - refactor to fix bug when querying all lambdas #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
lambda_info - refactor to fix bug when querying all lambdas Depends-On: ansible/ansible-zuul-jobs#1558 SUMMARY Fix bug that forces query: config when getting info for all lambdas. Refactored to return the expected info Add extra cleanup at end of tests Fixes #1151 ISSUE TYPE Bugfix Pull Request COMPONENT NAME lambda_info ADDITIONAL INFORMATION This module also currently returns a dict of dicts (as opposed to a list of dicts), but I wanted to keep the scope of this PR to fixing the bug. Reviewed-by: Mark Chappell <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None> (cherry picked from commit 0c76aed)
|
cc @jillr @markuman @pjodouin @s-hertel @steynovich @tremble |
ansibullbot
added
bug
tremble
approved these changes
Jun 3, 2022
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-3/0c76aedd4700a85ad6ee6971ffb787f2a2df1c2b/pr-1152
branch
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…nsible-collections#1253) route53_health_check: Fix "Name" tag key removal idempotentcy issue SUMMARY Depends-On: ansible-collections#1280 Fixes ansible-collections#1188 When using health_check_name as unique identifier (setting use_unique_names: True and providing a health_check_name) and health_check tags are set, Current logic for adding name to a health_check causes an issue when rerunning the create/update task. While ideally it should be idempotent, it removes the 'Name' tag (used for health_check_name) causing removal of health check name. ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_health_check ADDITIONAL INFORMATION To test, run the following sample playbook task twice Expected output: Health check name should not disapper (i.e. 'Name' tag should not get removed on rerun) --- - hosts: localhost gather_facts: False tasks: - name: Create a health-check amazon.aws.route53_health_check: health_check_name: my-test-hc use_unique_names: true fqdn: my-test-xyz.com type: HTTPS resource_path: / request_interval: 30 failure_threshold: 3 tags: Service: my-service Owner: my-test-xyz Lifecycle: dev Reviewed-by: Mark Chappell <None> Reviewed-by: GomathiselviS <None> Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Mike Graves <[email protected]> Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1152 as merged into main (0c76aed).
Depends-On: ansible/ansible-zuul-jobs#1558
SUMMARY
query: configwhen getting info for all lambdas. Refactored to return the expected infoFixes #1151
ISSUE TYPE
COMPONENT NAME
lambda_info
ADDITIONAL INFORMATION
This module also currently returns a dict of dicts (as opposed to a list of dicts), but I wanted to keep the scope of this PR to fixing the bug.