Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging fragment - Move simplest cases over to the docs fragment. #1182

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 30, 2022

Depends-On: ansible-collections/amazon.aws#844

SUMMARY

Migrate simplest cases over to the new docs fragment and add resource_tags as an alias to tags.

ISSUE TYPE
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

changelogs/fragments/1182-tagging.yml
plugins/modules/aws_glue_job.py
plugins/modules/aws_msk_cluster.py
plugins/modules/aws_secret.py
plugins/modules/aws_step_functions_state_machine.py
plugins/modules/dynamodb_table.py
plugins/modules/ec2_eip.py
plugins/modules/ec2_transit_gateway_vpc_attachment.py
plugins/modules/ec2_vpc_peer.py
plugins/modules/elb_application_lb.py
plugins/modules/elb_network_lb.py
plugins/modules/iam_role.py
plugins/modules/iam_user.py
plugins/modules/networkfirewall.py
plugins/modules/networkfirewall_policy.py
plugins/modules/networkfirewall_rule_group.py
plugins/modules/rds_cluster.py
plugins/modules/rds_instance.py
plugins/modules/rds_instance_snapshot.py
plugins/modules/rds_option_group.py
plugins/modules/rds_subnet_group.py
plugins/modules/redshift.py

ADDITIONAL INFORMATION

@ansibullbot ansibullbot added community_review docs module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) labels May 30, 2022
@github-actions
Copy link

github-actions bot commented May 30, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul

This comment was marked as outdated.

@tremble
Copy link
Contributor Author

tremble commented May 31, 2022

recheck

@tremble tremble requested a review from alinabuzachis May 31, 2022 08:11
@softwarefactory-project-zuul

This comment was marked as outdated.

@tremble
Copy link
Contributor Author

tremble commented May 31, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

ansible-galaxy-importer FAILURE in 5m 09s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 02s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 01s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 13s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 16m 07s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 13s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 44s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 31s
✔️ ansible-test-splitter SUCCESS in 2m 31s
✔️ integration-community.aws-1 SUCCESS in 36m 26s
✔️ integration-community.aws-2 SUCCESS in 7m 51s
integration-community.aws-3 TIMED_OUT in 1h 00m 45s
✔️ integration-community.aws-4 SUCCESS in 51m 23s
integration-community.aws-5 TIMED_OUT in 1h 01m 08s
integration-community.aws-6 TIMED_OUT in 1h 00m 44s
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@alinabuzachis
Copy link
Contributor

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

ansible-galaxy-importer FAILURE in 3m 49s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 40s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 24s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 30s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 22s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 41s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 13m 02s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 52s
✔️ ansible-test-splitter SUCCESS in 2m 24s
✔️ integration-community.aws-1 SUCCESS in 47m 24s
✔️ integration-community.aws-2 SUCCESS in 7m 41s
integration-community.aws-3 TIMED_OUT in 1h 00m 39s
✔️ integration-community.aws-4 SUCCESS in 49m 39s
✔️ integration-community.aws-5 SUCCESS in 57m 18s
integration-community.aws-6 TIMED_OUT in 1h 00m 52s
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble force-pushed the tagging/docs_simple branch from 1f23b75 to c39debc Compare June 1, 2022 10:45
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 4m 32s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 47s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 34s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 20s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 15m 03s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 19s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 59s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 8m 02s
✔️ ansible-test-splitter SUCCESS in 2m 54s
✔️ integration-community.aws-1 SUCCESS in 43m 23s
✔️ integration-community.aws-2 SUCCESS in 8m 28s
✔️ integration-community.aws-3 SUCCESS in 48m 08s
✔️ integration-community.aws-4 SUCCESS in 48m 24s
✔️ integration-community.aws-5 SUCCESS in 29m 49s
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 1, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 4m 31s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 57s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 20s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 21s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 13m 57s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 31s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 30s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 56s
✔️ ansible-test-splitter SUCCESS in 2m 30s
✔️ integration-community.aws-1 SUCCESS in 49m 45s
✔️ integration-community.aws-2 SUCCESS in 7m 57s
✔️ integration-community.aws-3 SUCCESS in 48m 19s
✔️ integration-community.aws-4 SUCCESS in 46m 39s
✔️ integration-community.aws-5 SUCCESS in 28m 30s
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b11ffae into ansible-collections:main Jun 1, 2022
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 2, 2022
)

Tagging fragment - dynamodb_table - Move over to the docs fragment.

SUMMARY
The dynamodb tests are slow enough to cause test timeouts when combined with too many other changed, split this off.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
dynamodb_table
ADDITIONAL INFORMATION
The change itself was approved on #1182
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 2, 2022
)

Tagging fragment - rds_instance_snapshot - Move over to the docs fragment.

SUMMARY
The rds_instance_snapshot tests are slow enough to cause test timeouts when combined with too many other changed, split this off.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
rds_instance_snapshot
ADDITIONAL INFORMATION
The change itself was approved on #1182
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 4, 2022
)

Tagging fragment - networkfirewall - Move over to the docs fragment 

SUMMARY
The networkfirewall tests are slow enough to be flakey, split this off.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
networkfirewall
ADDITIONAL INFORMATION
The change itself was approved on #1182
@tremble tremble deleted the tagging/docs_simple branch July 7, 2022 19:26
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…sible-collections#1182)

Tagging fragment - Move simplest cases over to the docs fragment.

Depends-On: ansible-collections/amazon.aws#844
SUMMARY
Migrate simplest cases over to the new docs fragment and add resource_tags as an alias to tags.
ISSUE TYPE

Docs Pull Request
Feature Pull Request

COMPONENT NAME
changelogs/fragments/1182-tagging.yml
plugins/modules/aws_glue_job.py
plugins/modules/aws_msk_cluster.py
plugins/modules/aws_secret.py
plugins/modules/aws_step_functions_state_machine.py
plugins/modules/dynamodb_table.py
plugins/modules/ec2_eip.py
plugins/modules/ec2_transit_gateway_vpc_attachment.py
plugins/modules/ec2_vpc_peer.py
plugins/modules/elb_application_lb.py
plugins/modules/elb_network_lb.py
plugins/modules/iam_role.py
plugins/modules/iam_user.py
plugins/modules/networkfirewall.py
plugins/modules/networkfirewall_policy.py
plugins/modules/networkfirewall_rule_group.py
plugins/modules/rds_cluster.py
plugins/modules/rds_instance.py
plugins/modules/rds_instance_snapshot.py
plugins/modules/rds_option_group.py
plugins/modules/rds_subnet_group.py
plugins/modules/redshift.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@b11ffae
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…sible-collections#1182)

Tagging fragment - Move simplest cases over to the docs fragment.

Depends-On: ansible-collections/amazon.aws#844
SUMMARY
Migrate simplest cases over to the new docs fragment and add resource_tags as an alias to tags.
ISSUE TYPE

Docs Pull Request
Feature Pull Request

COMPONENT NAME
changelogs/fragments/1182-tagging.yml
plugins/modules/aws_glue_job.py
plugins/modules/aws_msk_cluster.py
plugins/modules/aws_secret.py
plugins/modules/aws_step_functions_state_machine.py
plugins/modules/dynamodb_table.py
plugins/modules/ec2_eip.py
plugins/modules/ec2_transit_gateway_vpc_attachment.py
plugins/modules/ec2_vpc_peer.py
plugins/modules/elb_application_lb.py
plugins/modules/elb_network_lb.py
plugins/modules/iam_role.py
plugins/modules/iam_user.py
plugins/modules/networkfirewall.py
plugins/modules/networkfirewall_policy.py
plugins/modules/networkfirewall_rule_group.py
plugins/modules/rds_cluster.py
plugins/modules/rds_instance.py
plugins/modules/rds_instance_snapshot.py
plugins/modules/rds_option_group.py
plugins/modules/rds_subnet_group.py
plugins/modules/redshift.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@b11ffae
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…sible-collections#1182)

Tagging fragment - Move simplest cases over to the docs fragment.

Depends-On: ansible-collections/amazon.aws#844
SUMMARY
Migrate simplest cases over to the new docs fragment and add resource_tags as an alias to tags.
ISSUE TYPE

Docs Pull Request
Feature Pull Request

COMPONENT NAME
changelogs/fragments/1182-tagging.yml
plugins/modules/aws_glue_job.py
plugins/modules/aws_msk_cluster.py
plugins/modules/aws_secret.py
plugins/modules/aws_step_functions_state_machine.py
plugins/modules/dynamodb_table.py
plugins/modules/ec2_eip.py
plugins/modules/ec2_transit_gateway_vpc_attachment.py
plugins/modules/ec2_vpc_peer.py
plugins/modules/elb_application_lb.py
plugins/modules/elb_network_lb.py
plugins/modules/iam_role.py
plugins/modules/iam_user.py
plugins/modules/networkfirewall.py
plugins/modules/networkfirewall_policy.py
plugins/modules/networkfirewall_rule_group.py
plugins/modules/rds_cluster.py
plugins/modules/rds_instance.py
plugins/modules/rds_instance_snapshot.py
plugins/modules/rds_option_group.py
plugins/modules/rds_subnet_group.py
plugins/modules/redshift.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@b11ffae
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…sible-collections#1200)

Tagging fragment - rds_instance_snapshot - Move over to the docs fragment.

SUMMARY
The rds_instance_snapshot tests are slow enough to cause test timeouts when combined with too many other changed, split this off.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
rds_instance_snapshot
ADDITIONAL INFORMATION
The change itself was approved on ansible-collections#1182

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@9ca5540
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…sible-collections#1182)

Tagging fragment - Move simplest cases over to the docs fragment.

Depends-On: ansible-collections/amazon.aws#844
SUMMARY
Migrate simplest cases over to the new docs fragment and add resource_tags as an alias to tags.
ISSUE TYPE

Docs Pull Request
Feature Pull Request

COMPONENT NAME
changelogs/fragments/1182-tagging.yml
plugins/modules/aws_glue_job.py
plugins/modules/aws_msk_cluster.py
plugins/modules/aws_secret.py
plugins/modules/aws_step_functions_state_machine.py
plugins/modules/dynamodb_table.py
plugins/modules/ec2_eip.py
plugins/modules/ec2_transit_gateway_vpc_attachment.py
plugins/modules/ec2_vpc_peer.py
plugins/modules/elb_application_lb.py
plugins/modules/elb_network_lb.py
plugins/modules/iam_role.py
plugins/modules/iam_user.py
plugins/modules/networkfirewall.py
plugins/modules/networkfirewall_policy.py
plugins/modules/networkfirewall_rule_group.py
plugins/modules/rds_cluster.py
plugins/modules/rds_instance.py
plugins/modules/rds_instance_snapshot.py
plugins/modules/rds_option_group.py
plugins/modules/rds_subnet_group.py
plugins/modules/redshift.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@b11ffae
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…sible-collections#1182)

Tagging fragment - Move simplest cases over to the docs fragment.

Depends-On: ansible-collections/amazon.aws#844
SUMMARY
Migrate simplest cases over to the new docs fragment and add resource_tags as an alias to tags.
ISSUE TYPE

Docs Pull Request
Feature Pull Request

COMPONENT NAME
changelogs/fragments/1182-tagging.yml
plugins/modules/aws_glue_job.py
plugins/modules/aws_msk_cluster.py
plugins/modules/aws_secret.py
plugins/modules/aws_step_functions_state_machine.py
plugins/modules/dynamodb_table.py
plugins/modules/ec2_eip.py
plugins/modules/ec2_transit_gateway_vpc_attachment.py
plugins/modules/ec2_vpc_peer.py
plugins/modules/elb_application_lb.py
plugins/modules/elb_network_lb.py
plugins/modules/iam_role.py
plugins/modules/iam_user.py
plugins/modules/networkfirewall.py
plugins/modules/networkfirewall_policy.py
plugins/modules/networkfirewall_rule_group.py
plugins/modules/rds_cluster.py
plugins/modules/rds_instance.py
plugins/modules/rds_instance_snapshot.py
plugins/modules/rds_option_group.py
plugins/modules/rds_subnet_group.py
plugins/modules/redshift.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@b11ffae
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…sible-collections#1182)

Tagging fragment - Move simplest cases over to the docs fragment.

Depends-On: ansible-collections/amazon.aws#844
SUMMARY
Migrate simplest cases over to the new docs fragment and add resource_tags as an alias to tags.
ISSUE TYPE

Docs Pull Request
Feature Pull Request

COMPONENT NAME
changelogs/fragments/1182-tagging.yml
plugins/modules/aws_glue_job.py
plugins/modules/aws_msk_cluster.py
plugins/modules/aws_secret.py
plugins/modules/aws_step_functions_state_machine.py
plugins/modules/dynamodb_table.py
plugins/modules/ec2_eip.py
plugins/modules/ec2_transit_gateway_vpc_attachment.py
plugins/modules/ec2_vpc_peer.py
plugins/modules/elb_application_lb.py
plugins/modules/elb_network_lb.py
plugins/modules/iam_role.py
plugins/modules/iam_user.py
plugins/modules/networkfirewall.py
plugins/modules/networkfirewall_policy.py
plugins/modules/networkfirewall_rule_group.py
plugins/modules/rds_cluster.py
plugins/modules/rds_instance.py
plugins/modules/rds_instance_snapshot.py
plugins/modules/rds_option_group.py
plugins/modules/rds_subnet_group.py
plugins/modules/redshift.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@b11ffae
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…sible-collections#1182)

Tagging fragment - Move simplest cases over to the docs fragment.

Depends-On: ansible-collections/amazon.aws#844
SUMMARY
Migrate simplest cases over to the new docs fragment and add resource_tags as an alias to tags.
ISSUE TYPE

Docs Pull Request
Feature Pull Request

COMPONENT NAME
changelogs/fragments/1182-tagging.yml
plugins/modules/aws_glue_job.py
plugins/modules/aws_msk_cluster.py
plugins/modules/aws_secret.py
plugins/modules/aws_step_functions_state_machine.py
plugins/modules/dynamodb_table.py
plugins/modules/ec2_eip.py
plugins/modules/ec2_transit_gateway_vpc_attachment.py
plugins/modules/ec2_vpc_peer.py
plugins/modules/elb_application_lb.py
plugins/modules/elb_network_lb.py
plugins/modules/iam_role.py
plugins/modules/iam_user.py
plugins/modules/networkfirewall.py
plugins/modules/networkfirewall_policy.py
plugins/modules/networkfirewall_rule_group.py
plugins/modules/rds_cluster.py
plugins/modules/rds_instance.py
plugins/modules/rds_instance_snapshot.py
plugins/modules/rds_option_group.py
plugins/modules/rds_subnet_group.py
plugins/modules/redshift.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@b11ffae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review docs mergeit Merge the PR (SoftwareFactory) module module owner_pr PR created by owner/maintainer plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants