Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elb_network_lb - change default state from 'absent' to 'present' #1167

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 25, 2022

SUMMARY

change default state from 'absent' to 'present' to match our usual behaviour.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

elb_network_lb

ADDITIONAL INFORMATION

See also: ansible/ansible#65468

@tremble tremble requested review from alinabuzachis and markuman May 25, 2022 20:12
@tremble tremble added the do_not_backport This PR should not be backported to stable- branches unless absolutely necessary label May 25, 2022
@github-actions
Copy link

github-actions bot commented May 25, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module plugins plugin (any type) tests tests labels May 25, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 4m 45s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 55s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 19s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 20s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 14m 41s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 44s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 58s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 12s
✔️ ansible-test-splitter SUCCESS in 2m 33s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label May 26, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 6m 04s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 43s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 14s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 34s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 12s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 12m 00s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 21s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 19s
✔️ ansible-test-splitter SUCCESS in 2m 24s
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 38540cc into ansible-collections:main May 26, 2022
@tremble tremble deleted the deprecation/4.0.0/elb_network_lb branch July 7, 2022 19:27
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
Re-enable ec2_vpc_endpoint tests

SUMMARY
Tests were a little broken, fixed.
Also tried splitting out the VPC cleanup code to reduce copy&paste.
fixes: ansible-collections#475
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_vpc_endpoint
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review do_not_backport This PR should not be backported to stable- branches unless absolutely necessary feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants