Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s3_sync - drop unused retries parameter #1166

Merged
merged 1 commit into from
May 26, 2022
Merged

s3_sync - drop unused retries parameter #1166

merged 1 commit into from
May 26, 2022

Conversation

tremble
Copy link
Contributor

@tremble tremble commented May 25, 2022

SUMMARY

The retries parameter was never used, remove it.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

s3_sync

ADDITIONAL INFORMATION

See also: ansible/ansible#63989

@tremble tremble requested review from alinabuzachis and markuman May 25, 2022 19:48
@ansibullbot
Copy link

cc @jillr @markuman @s-hertel
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) small_patch Hopefully easy to review labels May 25, 2022
@github-actions
Copy link

github-actions bot commented May 25, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

❌ ansible-galaxy-importer FAILURE in 4m 09s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 50s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 24s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 43s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 15m 57s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 36s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 25s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 41s
✔️ ansible-test-splitter SUCCESS in 2m 38s
✔️ integration-community.aws-1 SUCCESS in 7m 22s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the do_not_backport This PR should not be backported to stable- branches unless absolutely necessary label May 25, 2022
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label May 26, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

❌ ansible-galaxy-importer FAILURE in 5m 05s (non-voting)
✔️ build-ansible-collection SUCCESS in 6m 26s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 04s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 13s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 42s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 36s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 01s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 08s
✔️ ansible-test-splitter SUCCESS in 2m 35s
✔️ integration-community.aws-1 SUCCESS in 7m 47s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit ce0e440 into ansible-collections:main May 26, 2022
@renovate renovate bot mentioned this pull request Jun 24, 2022
Merged
1 task
@tremble tremble deleted the deprecation/4.0.0/s3_sync branch July 7, 2022 19:27
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble
Cleanup integration tests after all of the module renames (ansible-co…
0828cb5 
…llections#1166)

Cleanup integration tests after all of the module renames

SUMMARY
A lot of modules were renamed prior to 5.0.0, update the integration tests to take this into account.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/integration
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuman markuman markuman approved these changes

@alinabuzachis alinabuzachis Awaiting requested review from alinabuzachis

Assignees
No one assigned
Labels
community_review do_not_backport This PR should not be backported to stable- branches unless absolutely necessary feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module module needs_triage owner_pr PR created by owner/maintainer plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tremble @ansibullbot @markuman