route53: add support for GeoLocation parameter #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
WIP
mandar242
changed the title
jatorcasso
reviewed
May 6, 2022
mandar242
force-pushed
the
route53_add_geo_location
branch
from
3b3fbb0 to
ff450d6
Compare
s-hertel
reviewed
May 7, 2022
alinabuzachis
requested changes
May 9, 2022
mandar242
force-pushed
the
route53_add_geo_location
branch
from
9f4c373 to
4f3b216
Compare
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #1144 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 10, 2022
route53: add support for GeoLocation parameter SUMMARY Added support for GeoLocation parameter to community.aws.route53 Fixes #89. ISSUE TYPE Feature Pull Request COMPONENT NAME route53 ADDITIONAL INFORMATION Uses https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/route53.html#Route53.Client.change_resource_record_sets Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Sloane Hertel <None> Reviewed-by: Alina Buzachis <None> (cherry picked from commit 29e51f9)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 11, 2022
[PR #1117/29e51f9e backport][stable-3] route53: add support for GeoLocation parameter This is a backport of PR #1117 as merged into main (29e51f9). SUMMARY Added support for GeoLocation parameter to community.aws.route53 Fixes #89. ISSUE TYPE Feature Pull Request COMPONENT NAME route53 ADDITIONAL INFORMATION Uses https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/route53.html#Route53.Client.change_resource_record_sets Reviewed-by: Alina Buzachis <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Aug 2, 2022
route53: Restore support for zero weighted DNS records SUMMARY In #1117 (comment) and https://github.com/ansible-collections/community.aws/pull/1117/files#r869391659 this line was recommended to be simplified, but not any will also return true if weight_in has a value of 0, not only when it is None Fixes #1378 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53 ADDITIONAL INFORMATION Previously it was possible to create weighted records with a weight of 0. Currently the playbook below returns the error: You have specified identifier which makes sense only if you specify one of: weight, region, geo_location or failover. - name: Bug demo hosts: localhost tasks: - name: Set 0 weight for old env route53: wait: yes ttl: '5' type: 'CNAME' identifier: old overwrite: yes record: 'record.example.com.' zone: 'example.com.' value: 'record-old.example.com.' weight: '0' state: present Reviewed-by: Mark Chappell <None>
patchback bot
pushed a commit
that referenced
this pull request
Aug 2, 2022
route53: Restore support for zero weighted DNS records SUMMARY In #1117 (comment) and https://github.com/ansible-collections/community.aws/pull/1117/files#r869391659 this line was recommended to be simplified, but not any will also return true if weight_in has a value of 0, not only when it is None Fixes #1378 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53 ADDITIONAL INFORMATION Previously it was possible to create weighted records with a weight of 0. Currently the playbook below returns the error: You have specified identifier which makes sense only if you specify one of: weight, region, geo_location or failover. - name: Bug demo hosts: localhost tasks: - name: Set 0 weight for old env route53: wait: yes ttl: '5' type: 'CNAME' identifier: old overwrite: yes record: 'record.example.com.' zone: 'example.com.' value: 'record-old.example.com.' weight: '0' state: present Reviewed-by: Mark Chappell <None> (cherry picked from commit 9195021)
patchback bot
pushed a commit
that referenced
this pull request
Aug 2, 2022
route53: Restore support for zero weighted DNS records SUMMARY In #1117 (comment) and https://github.com/ansible-collections/community.aws/pull/1117/files#r869391659 this line was recommended to be simplified, but not any will also return true if weight_in has a value of 0, not only when it is None Fixes #1378 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53 ADDITIONAL INFORMATION Previously it was possible to create weighted records with a weight of 0. Currently the playbook below returns the error: You have specified identifier which makes sense only if you specify one of: weight, region, geo_location or failover. - name: Bug demo hosts: localhost tasks: - name: Set 0 weight for old env route53: wait: yes ttl: '5' type: 'CNAME' identifier: old overwrite: yes record: 'record.example.com.' zone: 'example.com.' value: 'record-old.example.com.' weight: '0' state: present Reviewed-by: Mark Chappell <None> (cherry picked from commit 9195021)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Aug 2, 2022
[PR #1379/9195021f backport][stable-4] route53: Restore support for zero weighted DNS records This is a backport of PR #1379 as merged into main (9195021). SUMMARY In #1117 (comment) and https://github.com/ansible-collections/community.aws/pull/1117/files#r869391659 this line was recommended to be simplified, but not any will also return true if weight_in has a value of 0, not only when it is None Fixes #1378 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53 ADDITIONAL INFORMATION Previously it was possible to create weighted records with a weight of 0. Currently the playbook below returns the error: You have specified identifier which makes sense only if you specify one of: weight, region, geo_location or failover. - name: Bug demo hosts: localhost tasks: - name: Set 0 weight for old env route53: wait: yes ttl: '5' type: 'CNAME' identifier: old overwrite: yes record: 'record.example.com.' zone: 'example.com.' value: 'record-old.example.com.' weight: '0' state: present Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Aug 2, 2022
[PR #1379/9195021f backport][stable-3] route53: Restore support for zero weighted DNS records This is a backport of PR #1379 as merged into main (9195021). SUMMARY In #1117 (comment) and https://github.com/ansible-collections/community.aws/pull/1117/files#r869391659 this line was recommended to be simplified, but not any will also return true if weight_in has a value of 0, not only when it is None Fixes #1378 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53 ADDITIONAL INFORMATION Previously it was possible to create weighted records with a weight of 0. Currently the playbook below returns the error: You have specified identifier which makes sense only if you specify one of: weight, region, geo_location or failover. - name: Bug demo hosts: localhost tasks: - name: Set 0 weight for old env route53: wait: yes ttl: '5' type: 'CNAME' identifier: old overwrite: yes record: 'record.example.com.' zone: 'example.com.' value: 'record-old.example.com.' weight: '0' state: present Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
) route53: add support for GeoLocation parameter SUMMARY Added support for GeoLocation parameter to community.aws.route53 Fixes ansible-collections#89. ISSUE TYPE Feature Pull Request COMPONENT NAME route53 ADDITIONAL INFORMATION Uses https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/route53.html#Route53.Client.change_resource_record_sets Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Sloane Hertel <None> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@29e51f9
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ctions#1379) route53: Restore support for zero weighted DNS records SUMMARY In ansible-collections#1117 (comment) and https://github.com/ansible-collections/community.aws/pull/1117/files#r869391659 this line was recommended to be simplified, but not any will also return true if weight_in has a value of 0, not only when it is None Fixes ansible-collections#1378 ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53 ADDITIONAL INFORMATION Previously it was possible to create weighted records with a weight of 0. Currently the playbook below returns the error: You have specified identifier which makes sense only if you specify one of: weight, region, geo_location or failover. - name: Bug demo hosts: localhost tasks: - name: Set 0 weight for old env route53: wait: yes ttl: '5' type: 'CNAME' identifier: old overwrite: yes record: 'record.example.com.' zone: 'example.com.' value: 'record-old.example.com.' weight: '0' state: present Reviewed-by: Mark Chappell <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@9195021
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…_ownership_controls (ansible-collections#1117) s3_object - Be more defensive when checking the results of get_bucket_ownership_controls SUMMARY Scaleway have half-implemented get_bucket_ownership_controls, but don't return any rules. Be a little more defensive when checking the return value of get_bucket_ownership_controls. The API doesn't strictly say a Rule will always be returned. Fixes: ansible-collections#1115 ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_object ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Added support for
GeoLocationparameter tocommunity.aws.route53Fixes #89.
ISSUE TYPE
COMPONENT NAME
route53
ADDITIONAL INFORMATION
Uses https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/route53.html#Route53.Client.change_resource_record_sets