Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare 3.2.1 #1074

Merged
merged 1 commit into from
Apr 16, 2022
Merged

prepare 3.2.1 #1074

merged 1 commit into from
Apr 16, 2022

Conversation

markuman
Copy link
Member

SUMMARY

tiny bugfix release that reverts a breaking change

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • ec2_asg
  • iam_role
ADDITIONAL INFORMATION

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label Apr 16, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 86d0535 into ansible-collections:stable-3 Apr 16, 2022
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…sible-collections#1169)

rds_param_group: WARN on updating DBParameterGroupFamily (engine)

SUMMARY

Fixes ansible-collections#1074
Added a check to WARN the task while modifying/updating rds_param_group if task tries to change DB parameter group family.
As AWS Documentation specifies that,
The DB parameter group family can't be changed when updating a DB parameter group.


ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

rds_param_group
ADDITIONAL INFORMATION



Steps to reproduce

Create rds Param group

- name: Create a param group
  hosts: localhost
  gather_facts: false
  tasks:
    - name: create test rds db parameter group
      amazon.aws.rds_param_group:
        name: "test-parameter-group"
        description: test rpg
        state: present
        engine: "aurora-postgresql13"


Try to change engine (family), with the fix in PR task should throw warning.

- name: Create a param group
  hosts: localhost
  gather_facts: false
  tasks:
    - name: create test rds db parameter group
      amazon.aws.rds_param_group:
        name: "test-parameter-group"
        description: test rpg
        state: present
        engine: "aurora-postgresql14"

Reviewed-by: Jill R <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mandar Kulkarni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review docs mergeit Merge the PR (SoftwareFactory) needs_triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants