-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for load_balancing_algorithm_type in elb_target_group #1016
Add support for load_balancing_algorithm_type in elb_target_group #1016
Conversation
I've tried that also in the past #282
So when a target group is attached to a classic loadbalancer, or to an NLB, it will fail. |
@markuman i think that's fine, I'll document it so it's clear, there's another example already in the module "deregistration_connection_termination" that only applies to NLB We could also limit to if protocol is http / https I think but probably documenting is enough |
754d3bb
to
f906a1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marknet15 Thank you. Only two very small things, otherwise, LGTM!
Co-authored-by: Alina Buzachis <[email protected]>
Co-authored-by: Alina Buzachis <[email protected]>
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #1022 🤖 @patchback |
) Add support for load_balancing_algorithm_type in elb_target_group SUMMARY AWS has supported setting the load_balancing.algorithm.type for a little while now allowing you to choose between either round_robin or least_oustanding_requests this PR adds support for setting the new parameter. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_target_group ADDITIONAL INFORMATION https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/elbv2.html#ElasticLoadBalancingv2.Client.modify_target_group_attributes https://aws.amazon.com/about-aws/whats-new/2019/11/application-load-balancer-now-supports-least-outstanding-requests-algorithm-for-load-balancing-requests/ Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <[email protected]> (cherry picked from commit 10137a2)
) (#1022) [PR #1016/10137a2a backport][stable-3] Add support for load_balancing_algorithm_type in elb_target_group This is a backport of PR #1016 as merged into main (10137a2). SUMMARY AWS has supported setting the load_balancing.algorithm.type for a little while now allowing you to choose between either round_robin or least_oustanding_requests this PR adds support for setting the new parameter. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_target_group ADDITIONAL INFORMATION https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/elbv2.html#ElasticLoadBalancingv2.Client.modify_target_group_attributes https://aws.amazon.com/about-aws/whats-new/2019/11/application-load-balancer-now-supports-least-outstanding-requests-algorithm-for-load-balancing-requests/
Add changelog and update FQDN SUMMARY Update FQDN and add missing changelog ansible-collections#997 ISSUE TYPE Docs Pull Request COMPONENT NAME cloudtrail Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mike Graves <[email protected]> Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: Mark Chappell <None>
SUMMARY
AWS has supported setting the
load_balancing.algorithm.type
for a little while now allowing you to choose between eitherround_robin
orleast_oustanding_requests
this PR adds support for setting the new parameter.ISSUE TYPE
COMPONENT NAME
elb_target_group
ADDITIONAL INFORMATION
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/elbv2.html#ElasticLoadBalancingv2.Client.modify_target_group_attributes
https://aws.amazon.com/about-aws/whats-new/2019/11/application-load-balancer-now-supports-least-outstanding-requests-algorithm-for-load-balancing-requests/