Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New modules: Transit Gateway VPC attachments #1004

Merged
merged 1 commit into from
May 2, 2022
Merged

New modules: Transit Gateway VPC attachments #1004

merged 1 commit into from
May 2, 2022

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Mar 17, 2022

SUMMARY

Adds support for EC2 Transit Gateway VPC attachments

Does not support accepting / rejecting attachments at this time.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

ec2_transit_gateway_vpc_attachment
ec2_transit_gateway_vpc_attachment_info

ADDITIONAL INFORMATION

@ansibullbot
Copy link

cc @jillr @markuman @s-hertel
click here for bot help

@ansibullbot ansibullbot added community_review integration tests/integration module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests labels Mar 17, 2022
@softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@tremble tremble mentioned this pull request Apr 5, 2022
Merged
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@tremble
Copy link
Contributor Author

tremble commented Apr 5, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@tremble
Copy link
Contributor Author

tremble commented Apr 8, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@tremble
Copy link
Contributor Author

tremble commented Apr 19, 2022

@gravesm - I can't reproduce the failure in my local account, is there any chance you could take a look and see if something's blocked in the logs?

@gravesm
Copy link
Member

gravesm commented Apr 19, 2022

Sure, I'll see if I can figure out what's going on.

@neilkatin
Copy link

For what it's worth: I have tried the branched code and it works for me.

Being able to actually attach a transit gateway to a VPC is an essential task to make use of Transit Gateways.

@tremble
Copy link
Contributor Author

tremble commented Apr 19, 2022

For what it's worth: I have tried the branched code and it works for me.

Thanks for trying that out, I suspect Amazon's doing something 'clever' behind the scenes. The CI account is relatively restricted so there's probably a missing permission that's not being exposed, possibly even one that's only needed the very first time you attach a VPC (Amazon does some interesting things behind the scenes in a few places)

@gravesm
Copy link
Member

gravesm commented Apr 19, 2022

I can see the attachment gets created, but it just sits in the pending state for a while and then eventually moves to failed. There's nowhere I can find that provides any information on why it failed. I'll keep poking around at it, but if you have any suggestions as to where to look for more info on why it failed, I'd be interested in hearing them.

jillr added a commit to jillr/aws-terminator that referenced this pull request Apr 21, 2022
@jillr
Policies for transit gateway
b2c129c 
Enable service-linked role and add terminator classes for VPC transit
gateways.

Related to: ansible-collections/community.aws#1004
@jillr jillr mentioned this pull request Apr 21, 2022
Merged
@tremble
Copy link
Contributor Author

tremble commented Apr 22, 2022

@gravesm Looks like @jillr found the kind of thing I was referring to, sorry for not responding.

@tremble
Copy link
Contributor Author

tremble commented Apr 26, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label May 2, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 9494e76 into ansible-collections:main May 2, 2022
@tremble tremble mentioned this pull request May 16, 2022
Closed
@tremble tremble deleted the tgw/attachments branch July 7, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@markuman markuman Awaiting requested review from markuman

Assignees
No one assigned
Labels
community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tremble @ansibullbot @gravesm @neilkatin @alinabuzachis