Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI error in aws_acm module, ansible-doc error #902

Closed
1 task done
sebastien-rosset opened this issue Jan 29, 2022 · 5 comments · Fixed by #903
Closed
1 task done

CI error in aws_acm module, ansible-doc error #902

sebastien-rosset opened this issue Jan 29, 2022 · 5 comments · Fixed by #903
Labels
bug This issue/PR relates to a bug has_pr module module plugins plugin (any type)

Comments

@sebastien-rosset
Copy link
Contributor

sebastien-rosset commented Jan 29, 2022 •
edited
Loading

Summary

When I submit a documentation improvement for the ec2_launch_template module in PR #901, a CI error occurs because of the aws_acm module. The error is unrelated to the ec2_launch_template module.

Specifically, Error running ansible-doc:
https://ansible.softwarefactory-project.io/zuul/build/3db5b0c9ae494d6bb29ffe33704dced2

ERROR! module community.aws.aws_acm missing documentation (or could not parse documentation):
unknown doc_fragment(s) in file /tmp/tmpllc6ru0q/ansible_collections/community/aws/plugins/modules/aws_acm.py:
 amazon.aws.aws, amazon.aws.ec2\n'\''

Issue Type

Bug Report

Component Name

aws_acm

Ansible Version

$ ansible --version

Collection Versions

$ ansible-galaxy collection list

AWS SDK versions

$ pip show boto boto3 botocore

Configuration

$ ansible-config dump --only-changed

OS / Environment

No response

Steps to Reproduce

This happened while submitting PR #901

https://ansible.softwarefactory-project.io/zuul/build/3db5b0c9ae494d6bb29ffe33704dced2

Expected Results

I expected the CI job would complete successfully. Instead, the CI job failed in the aws_acm module sanity.

Actual Results



Code of Conduct


    

  •  I agree to follow the Ansible Code of Conduct
    • 


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @sebastien-rosset
sebastien-rosset




        changed the title
CI error in aws_acm module

CI error in aws_acm module, ansible-doc error


      Jan 29, 2022

    

  



  

  

    
  


  

      

    @sebastien-rosset
sebastien-rosset



    mentioned this issue
    
      Jan 29, 2022
    





  


  

      
   Merged

  







  









      

  
      



  

  @ansibullbot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          
Files identified in the description:



If these files are inaccurate, please update the component name section of the description or use the !component bot command.


click here for bot help


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @ansibullbot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          
cc @jillr @markuman @matt-telstra @s-hertel @tremble

click here for bot help


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @ansibullbot
ansibullbot




            added
      

  bug

  This issue/PR relates to a bug

      

  has_pr


      

  module

  module

      

  needs_triage


      

  plugins

  plugin (any type)

  labels


      Jan 29, 2022

    

  



  

  

    
  


  

      

    @sebastien-rosset
sebastien-rosset



    mentioned this issue
    
      Jan 29, 2022
    





  


  

      
   Merged

  







  









      

  
      



  

  @markuman





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
No, the CI error is non-voting.




ansible-galaxy-importer : FAILURE in 4m 06s (non-voting)



      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            







      

  
      



  

  @sebastien-rosset





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  Author


  


  

    

  





      


        


  
    

      
          
I didn't state it's voting or non voting. I'm saying there is a CI error. As a first time contributor, it's quite unsettling to see that almost every single PR causes unrelated issues.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          

  

    
  


  

      

    @markuman
markuman



    mentioned this issue
    
      Jan 29, 2022
    





  


  

      
   Merged

  







  









      

  
      



  

  @markuman





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          


I didn't state it's voting or non voting. I'm saying there is a CI error.




Ok, I wanted to reply to #901 (comment) :)

I think there are several documentation errors. That's why  the first CI is set to non-voting.




As a first time contributor, it's quite unsettling to see that almost every single PR causes unrelated issues.




Yes. I fully agree.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    


  


  
    
  
  

    
  softwarefactory-project-zuul bot

      pushed a commit
      that referenced
      this issue

    
      Jan 30, 2022
    
    

      


  

    

      


  

      
        @markuman
  





      

        
          fix yamllint errors (#903)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          d52052a
        
      

    

  

    

      
aws_acm: fix yamllint errors in docs section

SUMMARY
Closes: #902
ISSUE TYPE


Docs Pull Request

COMPONENT NAME
aws_acm
ADDITIONAL INFORMATION



  1:1       warning  missing document start "---"  (document-start)
  2:81      error    line too long (88 > 80 characters)  (line-length)
  5:81      error    line too long (89 > 80 characters)  (line-length)
  9:81      error    line too long (86 > 80 characters)  (line-length)
  11:81     error    line too long (100 > 80 characters)  (line-length)
  32:81     error    line too long (87 > 80 characters)  (line-length)
  36:81     error    line too long (98 > 80 characters)  (line-length)
  41:81     error    line too long (98 > 80 characters)  (line-length)
  43:81     error    line too long (105 > 80 characters)  (line-length)
  49:81     error    line too long (84 > 80 characters)  (line-length)
  56:81     error    line too long (102 > 80 characters)  (line-length)
  61:81     error    line too long (87 > 80 characters)  (line-length)
  69:81     error    line too long (91 > 80 characters)  (line-length)
  79:81     error    line too long (92 > 80 characters)  (line-length)
  88:81     error    line too long (85 > 80 characters)  (line-length)
  105:81    error    line too long (83 > 80 characters)  (line-length)
  123:1     error    wrong indentation: expected 2 but found 0  (indentation)
  124:17    error    no new line character at the end of file  (new-line-at-end-of-file)

Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Mark Chappell <None>

    




    

  




  


  
    
  
  

    
  patchback bot

      pushed a commit
      that referenced
      this issue

    
      Jan 30, 2022
    
    

      


  

    

      


  

      
        @markuman
      
        @patchback
  





      

        
          fix yamllint errors (#903)
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          ff57d4f
        
      

    

  

    

      
aws_acm: fix yamllint errors in docs section

SUMMARY
Closes: #902
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
aws_acm
ADDITIONAL INFORMATION

  1:1       warning  missing document start "---"  (document-start)
  2:81      error    line too long (88 > 80 characters)  (line-length)
  5:81      error    line too long (89 > 80 characters)  (line-length)
  9:81      error    line too long (86 > 80 characters)  (line-length)
  11:81     error    line too long (100 > 80 characters)  (line-length)
  32:81     error    line too long (87 > 80 characters)  (line-length)
  36:81     error    line too long (98 > 80 characters)  (line-length)
  41:81     error    line too long (98 > 80 characters)  (line-length)
  43:81     error    line too long (105 > 80 characters)  (line-length)
  49:81     error    line too long (84 > 80 characters)  (line-length)
  56:81     error    line too long (102 > 80 characters)  (line-length)
  61:81     error    line too long (87 > 80 characters)  (line-length)
  69:81     error    line too long (91 > 80 characters)  (line-length)
  79:81     error    line too long (92 > 80 characters)  (line-length)
  88:81     error    line too long (85 > 80 characters)  (line-length)
  105:81    error    line too long (83 > 80 characters)  (line-length)
  123:1     error    wrong indentation: expected 2 but found 0  (indentation)
  124:17    error    no new line character at the end of file  (new-line-at-end-of-file)

Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Mark Chappell <None>
(cherry picked from commit d52052a)

    




    

  




  

  

    
  


  

      

    @patchback
patchback
bot


    mentioned this issue
    
      Jan 30, 2022
    





  


  

      
   Merged

  







  




  


  
    
  
  

    
  tremble 

      pushed a commit
      that referenced
      this issue

    
      Jan 30, 2022
    
    

      


  

    

      


  

      
        @patchback
      
        @markuman
  





      

        
          fix yamllint errors (#903) (#907)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          58b38cb
        
      

    

  

    

      
aws_acm: fix yamllint errors in docs section

SUMMARY
Closes: #902
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
aws_acm
ADDITIONAL INFORMATION

  1:1       warning  missing document start "---"  (document-start)
  2:81      error    line too long (88 > 80 characters)  (line-length)
  5:81      error    line too long (89 > 80 characters)  (line-length)
  9:81      error    line too long (86 > 80 characters)  (line-length)
  11:81     error    line too long (100 > 80 characters)  (line-length)
  32:81     error    line too long (87 > 80 characters)  (line-length)
  36:81     error    line too long (98 > 80 characters)  (line-length)
  41:81     error    line too long (98 > 80 characters)  (line-length)
  43:81     error    line too long (105 > 80 characters)  (line-length)
  49:81     error    line too long (84 > 80 characters)  (line-length)
  56:81     error    line too long (102 > 80 characters)  (line-length)
  61:81     error    line too long (87 > 80 characters)  (line-length)
  69:81     error    line too long (91 > 80 characters)  (line-length)
  79:81     error    line too long (92 > 80 characters)  (line-length)
  88:81     error    line too long (85 > 80 characters)  (line-length)
  105:81    error    line too long (83 > 80 characters)  (line-length)
  123:1     error    wrong indentation: expected 2 but found 0  (indentation)
  124:17    error    no new line character at the end of file  (new-line-at-end-of-file)

Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Mark Chappell <None>
(cherry picked from commit d52052a)

Co-authored-by: Markus Bergholz <[email protected]>

    




    

  




  


  
    
  
  

    
  abikouo 

      pushed a commit
        to abikouo/community.aws
      that referenced
      this issue

    
      Oct 24, 2023
    
    

      


  

    

      


  

      
        @tremble
  





      

        
          Remove old lookup unit tests (ansible-collections#902)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          5693b52
        
      

    

  

    

      
Remove old lookup unit tests

SUMMARY
Remove the unit tests for the aws_ssm and aws_secret lookup plugins.
These unit tests weren't testing individual functions, they were testing the 'whole' module, and as such are brittle and break if the underlying implementation is updated (such as a refactor).  Since we now have supported integration tests, remove the unit tests.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/lookup/aws_ssm.py
plugins/lookup/aws_secret.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    bug

  This issue/PR relates to a bug
  

    has_pr

  

    module

  module
  

    plugins

  plugin (any type)








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




          
  
Successfully merging a pull request may close this issue.





    


  
          
      aws_acm: fix yamllint errors in docs section






    
  




      

    

  
      

  

    

      3 participants
    

    

        
          @markuman 
        
          @sebastien-rosset 
        
          @ansibullbot