Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_vpc_nat_gateway should support tags #345

Closed
acrawly opened this issue Jan 5, 2021 · 2 comments · Fixed by #372
Closed

ec2_vpc_nat_gateway should support tags #345

acrawly opened this issue Jan 5, 2021 · 2 comments · Fixed by #372
Assignees
@alinabuzachis
Labels
affects_2.10 feature This issue/PR relates to a feature request module module

Comments

@acrawly
Copy link

acrawly commented Jan 5, 2021

SUMMARY

The ec2_vpc_nat_gateway module does not support tags and it should. NAT Gateways support tags in AWS.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

The module name is ec2_vpc_nat_gateway

ADDITIONAL INFORMATION

The ec2_vpc_nat_gateway should accept a dictionary of tags, like the internet gateway module (as documented here).

- name: setup NAT gateways
  tags: always
  ec2_vpc_nat_gateway:
    profile: your_aws_profile
    state: present
    region: us-west-1
    subnet_id: "{{ item }}"
    if_exist_do_not_create: yes
    tags: #<-- This is currently not supported
      - Name: MyNATGateway
      - Purpuse: NATing things 
  loop: "{{nat_subnet_list}}" #This is an array of subnet IDs in format `nat_subnet_id: subnet-12345, subnet-54321`
@alinabuzachis alinabuzachis self-assigned this Jan 6, 2021
@alinabuzachis alinabuzachis added feature This issue/PR relates to a feature request affects_2.10 labels Jan 6, 2021
@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

cc @Etherdaemon @jillr @jonhadfield @linuxdynasty @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added the module module label Jan 13, 2021
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this issue Jan 26, 2021
@alinabuzachis
Tags feature: support tags specification for NAT gateway (solves ansi…
70fd28f 
…ble-collections#345)

- implements tags feature for NAT gateway
- adds integration test tasks for tags feature
- refactor integration tests (overall) removing hard-coded parameters
- add missing integration test tasks without CHECK_MODE
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this issue Jan 26, 2021
@alinabuzachis
Tags feature: support tags specification for NAT gateway (solves ansi…
acaf280 
…ble-collections#345)

- implements tags feature for NAT gateway
- adds integration test tasks for tags feature
- refactor integration tests (overall) removing hard-coded parameters
- add missing integration test tasks without CHECK_MODE
@alinabuzachis alinabuzachis mentioned this issue Jan 26, 2021
Merged
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this issue Jan 26, 2021
@alinabuzachis
Tags feature: support tags specification for NAT gateway (solves ansi…
b2b7e26 
…ble-collections#345)

- implements tags feature for NAT gateway
- adds integration test tasks for tags feature
- refactor integration tests (overall) removing hard-coded parameters
- add missing integration test tasks without CHECK_MODE
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this issue Jan 26, 2021
@alinabuzachis
Tags feature: support tags specification for NAT gateway (solves ansi…
380f686 
…ble-collections#345)

- implements tags feature for NAT gateway
- adds integration test tasks for tags feature
- refactor integration tests (overall) removing hard-coded parameters
- add missing integration test tasks without CHECK_MODE
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this issue Jan 28, 2021
@alinabuzachis
Tags feature: support tags specification for NAT gateway (solves ansi…
5622828 
…ble-collections#345)

- implements tags feature for NAT gateway
- adds integration test tasks for tags feature
- refactor integration tests (overall) removing hard-coded parameters
- add missing integration test tasks without CHECK_MODE
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this issue Jan 29, 2021
@alinabuzachis
Tags feature: support tags specification for NAT gateway (ansible-col…
c0f5aa5 
…lections#345)

 * implement tags feature for NAT gateway
 * add integration test tasks for tags feature
 * refactor integration tests (overall) removing hard-coded parameters
 * add missing integration test tasks without CHECK_MODE

 * added code to support tags in ec2_vap_nat_gateway - return error 'NoneType' object has no attribute 'get' because of curr_tags seems to remain None
 * removed tests in check_mode because not working due to DRY_RUN_GATEWAY
 * Addressed reviewers comments

Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this issue Jan 29, 2021
@alinabuzachis
Tags feature: support tags specification for NAT gateway (ansible-col…
7f02154 
…lections#345)

 * implement tags feature for NAT gateway
 * add integration test tasks for tags feature
 * refactor integration tests (overall) removing hard-coded parameters
 * add missing integration test tasks without CHECK_MODE

 * added code to support tags in ec2_vap_nat_gateway - return error 'NoneType' object has no attribute 'get' because of curr_tags seems to remain None
 * removed tests in check_mode because not working due to DRY_RUN_GATEWAY
 * Addressed reviewers comments

Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this issue Jan 29, 2021
@alinabuzachis
Tags feature: support tags specification for NAT gateway (ansible-col…
8ca0e79 
…lections#345)

 * implement tags feature for NAT gateway
 * add integration test tasks for tags feature
 * refactor integration tests (overall) removing hard-coded parameters
 * add missing integration test tasks without CHECK_MODE
 * include until loop for some tasks as they failed during the integration

 * added code to support tags in ec2_vap_nat_gateway - return error 'NoneType' object has no attribute 'get' because of curr_tags seems to remain None
 * removed tests in check_mode because not working due to DRY_RUN_GATEWAY
 * Addressed reviewers comments

Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this issue Jan 29, 2021
@alinabuzachis
Tags feature: support tags specification for NAT gateway (ansible-col…
0fec3b1 
…lections#345)

 * implement tags feature for NAT gateway
 * add integration test tasks for tags feature
 * refactor integration tests (overall) removing hard-coded parameters
 * add missing integration test tasks without CHECK_MODE
 * include until loop for some tasks as they failed during the integration

 * added code to support tags in ec2_vap_nat_gateway - return error 'NoneType' object has no attribute 'get' because of curr_tags seems to remain None
 * removed tests in check_mode because not working due to DRY_RUN_GATEWAY
 * Addressed reviewers comments

Signed-off-by: Alina Buzachis <[email protected]>
tremble pushed a commit that referenced this issue Feb 1, 2021
@alinabuzachis
Tags feature: support tags specification for NAT gateway (#345) (#372)
b7afd18 
* implement tags feature for NAT gateway
 * add integration test tasks for tags feature
 * refactor integration tests (overall) removing hard-coded parameters
 * add missing integration test tasks without CHECK_MODE
 * include until loop for some tasks as they failed during the integration

 * added code to support tags in ec2_vap_nat_gateway - return error 'NoneType' object has no attribute 'get' because of curr_tags seems to remain None
 * removed tests in check_mode because not working due to DRY_RUN_GATEWAY
 * Addressed reviewers comments

Signed-off-by: Alina Buzachis <[email protected]>

Co-authored-by: Alina Buzachis <[email protected]>
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this issue Jul 16, 2021
@alinabuzachis
[promoted]Tags feature: support tags specification for NAT gateway (a…
0985f93 
…nsible-collections#345) (ansible-collections#372)

* implement tags feature for NAT gateway
 * add integration test tasks for tags feature
 * refactor integration tests (overall) removing hard-coded parameters
 * add missing integration test tasks without CHECK_MODE
 * include until loop for some tasks as they failed during the integration

 * added code to support tags in ec2_vap_nat_gateway - return error 'NoneType' object has no attribute 'get' because of curr_tags seems to remain None
 * removed tests in check_mode because not working due to DRY_RUN_GATEWAY
 * Addressed reviewers comments

Signed-off-by: Alina Buzachis <[email protected]>

Co-authored-by: Alina Buzachis <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@b7afd18
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this issue Jul 19, 2021
@alinabuzachis
Tags feature: support tags specification for NAT gateway (ansible-col…
304ecac 
…lections#345) (ansible-collections#372)

* implement tags feature for NAT gateway
 * add integration test tasks for tags feature
 * refactor integration tests (overall) removing hard-coded parameters
 * add missing integration test tasks without CHECK_MODE
 * include until loop for some tasks as they failed during the integration

 * added code to support tags in ec2_vap_nat_gateway - return error 'NoneType' object has no attribute 'get' because of curr_tags seems to remain None
 * removed tests in check_mode because not working due to DRY_RUN_GATEWAY
 * Addressed reviewers comments

Signed-off-by: Alina Buzachis <[email protected]>

Co-authored-by: Alina Buzachis <[email protected]>
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this issue Jul 19, 2021
@alinabuzachis
Tags feature: support tags specification for NAT gateway (ansible-col…
de7b209 
…lections#345) (ansible-collections#372)

* implement tags feature for NAT gateway
 * add integration test tasks for tags feature
 * refactor integration tests (overall) removing hard-coded parameters
 * add missing integration test tasks without CHECK_MODE
 * include until loop for some tasks as they failed during the integration

 * added code to support tags in ec2_vap_nat_gateway - return error 'NoneType' object has no attribute 'get' because of curr_tags seems to remain None
 * removed tests in check_mode because not working due to DRY_RUN_GATEWAY
 * Addressed reviewers comments

Signed-off-by: Alina Buzachis <[email protected]>

Co-authored-by: Alina Buzachis <[email protected]>
danielcotton pushed a commit to danielcotton/community.aws that referenced this issue Nov 23, 2021
@alinabuzachis @danielcotton
Tags feature: support tags specification for NAT gateway (ansible-col…
9986885 
…lections#345) (ansible-collections#372)

* implement tags feature for NAT gateway
 * add integration test tasks for tags feature
 * refactor integration tests (overall) removing hard-coded parameters
 * add missing integration test tasks without CHECK_MODE
 * include until loop for some tasks as they failed during the integration

 * added code to support tags in ec2_vap_nat_gateway - return error 'NoneType' object has no attribute 'get' because of curr_tags seems to remain None
 * removed tests in check_mode because not working due to DRY_RUN_GATEWAY
 * Addressed reviewers comments

Signed-off-by: Alina Buzachis <[email protected]>

Co-authored-by: Alina Buzachis <[email protected]>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this issue May 25, 2022
@goneri
s3_bucket/test: use one bucket per scenario (ansible-collections#345)
654a45c 
s3_bucket/test: use one bucket per scenario

Reviewed-by: Ansibullbot manages ticket workflow
             https://github.com/ansibullbot
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this issue May 25, 2022
@alinabuzachis @jillr
Tags feature: support tags specification for NAT gateway (ansible-col…
3b7728e 
…lections#345) (ansible-collections#372)

* implement tags feature for NAT gateway
 * add integration test tasks for tags feature
 * refactor integration tests (overall) removing hard-coded parameters
 * add missing integration test tasks without CHECK_MODE
 * include until loop for some tasks as they failed during the integration

 * added code to support tags in ec2_vap_nat_gateway - return error 'NoneType' object has no attribute 'get' because of curr_tags seems to remain None
 * removed tests in check_mode because not working due to DRY_RUN_GATEWAY
 * Addressed reviewers comments

Signed-off-by: Alina Buzachis <[email protected]>

Co-authored-by: Alina Buzachis <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@b7afd18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alinabuzachis alinabuzachis

Labels
affects_2.10 feature This issue/PR relates to a feature request module module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ec2_vpc_nat_gateway] Add tag support alinabuzachis/community.aws
3 participants
@acrawly @alinabuzachis @ansibullbot