Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_asg mixed_instance_policy does not support instances_distribution #231

Closed
JacobHenner opened this issue Sep 16, 2020 · 2 comments · Fixed by #232
Closed

ec2_asg mixed_instance_policy does not support instances_distribution #231

JacobHenner opened this issue Sep 16, 2020 · 2 comments · Fixed by #232
Labels
affects_2.10 feature This issue/PR relates to a feature request has_pr module module plugins plugin (any type)

Comments

@JacobHenner
Copy link
Contributor

SUMMARY

ec2_asg mixed_instance_policy does not support instances_distribution. It only supports setting multiple instance types. Instead, it should support all of the features in https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_MixedInstancesPolicy.html, not just instance type overrides.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

ec2_asg

ADDITIONAL INFORMATION

This would be useful for users trying to add spot instances to their ASGs.
JacobHenner added a commit to JacobHenner/community.aws that referenced this issue Sep 16, 2020
@JacobHenner
Fully support mixed instance policy
d05d2f7 
Previously, setting instances_distribution was not supported.
instances_distribution should be supported, to allow users to enable
spot instances within their mixed instance ASGs.

Note: The type and significance of the mixed_instance_policy has
changed. It now captures all of the mixed_instance_policy configuration
parameters, rather than just a list of instance types.

Fixes ansible-collections#231
@JacobHenner JacobHenner mentioned this issue Sep 16, 2020
Merged
JacobHenner added a commit to JacobHenner/community.aws that referenced this issue Sep 16, 2020
@JacobHenner
Fully support mixed instance policy
b97f709 
Previously, setting instances_distribution was not supported.
instances_distribution should be supported, to allow users to enable
spot instances within their mixed instance ASGs.

Note: The type and significance of the mixed_instance_policy has
changed. It now captures all of the mixed_instance_policy configuration
parameters, rather than just a list of instance types.

Fixes ansible-collections#231
JacobHenner added a commit to JacobHenner/community.aws that referenced this issue Sep 16, 2020
@JacobHenner
Fully support mixed instance policy
09b8b9b 
Previously, setting instances_distribution was not supported.
instances_distribution should be supported, to allow users to enable
spot instances within their mixed instance ASGs.

Note: The type and significance of the mixed_instance_policy has
changed. It now captures all of the mixed_instance_policy configuration
parameters, rather than just a list of instance types.

Fixes ansible-collections#231
JacobHenner added a commit to JacobHenner/community.aws that referenced this issue Sep 16, 2020
@JacobHenner
Fully support mixed instance policy
6baee97 
Previously, setting instances_distribution was not supported.
instances_distribution should be supported, to allow users to enable
spot instances within their mixed instance ASGs.

Note: The type and significance of the mixed_instance_policy has
changed. It now captures all of the mixed_instance_policy configuration
parameters, rather than just a list of instance types.

Fixes ansible-collections#231
JacobHenner added a commit to JacobHenner/community.aws that referenced this issue Sep 16, 2020
@JacobHenner
Fully support mixed instance policy
91e4cc2 
Previously, setting instances_distribution was not supported.
instances_distribution should be supported, to allow users to enable
spot instances within their mixed instance ASGs.

Note: The type and significance of the mixed_instance_policy has
changed. It now captures all of the mixed_instance_policy configuration
parameters, rather than just a list of instance types.

Fixes ansible-collections#231
@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

cc @garethr @jillr @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added affects_2.10 feature This issue/PR relates to a feature request has_pr module module needs_triage plugins plugin (any type) labels Sep 18, 2020
goneri pushed a commit to JacobHenner/community.aws that referenced this issue Feb 12, 2021
@JacobHenner @goneri
Fully support mixed instance policy
7bd3ac8 
Previously, setting instances_distribution was not supported.
instances_distribution should be supported, to allow users to enable
spot instances within their mixed instance ASGs.

Note: The type and significance of the mixed_instance_policy has
changed. It now captures all of the mixed_instance_policy configuration
parameters, rather than just a list of instance types.

Fixes ansible-collections#231
tremble pushed a commit that referenced this issue Mar 31, 2021
@JacobHenner
Fully support mixed instance policy (#232)
95ecf7d 
* Fully support mixed instance policy

Previously, setting instances_distribution was not supported.
instances_distribution should be supported, to allow users to enable
spot instances within their mixed instance ASGs.

Note: The type and significance of the mixed_instance_policy has
changed. It now captures all of the mixed_instance_policy configuration
parameters, rather than just a list of instance types.

Fixes #231

* Restore mixed_instances_policy backwards-compat

Restore mixed_instances_policy backwards compatibility by using
mixed_instances_policy_full to return full dictionary.

Also, fix some doc typos, add CHANGELOG fragment, and split into
separate test case.

Addresses feedback in #232

* Only return mixed_instances_policy_full if set
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this issue Jul 19, 2021
@JacobHenner
Fully support mixed instance policy (ansible-collections#232)
0fdb95e 
* Fully support mixed instance policy

Previously, setting instances_distribution was not supported.
instances_distribution should be supported, to allow users to enable
spot instances within their mixed instance ASGs.

Note: The type and significance of the mixed_instance_policy has
changed. It now captures all of the mixed_instance_policy configuration
parameters, rather than just a list of instance types.

Fixes ansible-collections#231

* Restore mixed_instances_policy backwards-compat

Restore mixed_instances_policy backwards compatibility by using
mixed_instances_policy_full to return full dictionary.

Also, fix some doc typos, add CHANGELOG fragment, and split into
separate test case.

Addresses feedback in ansible-collections#232

* Only return mixed_instances_policy_full if set
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this issue Jul 19, 2021
@JacobHenner
Fully support mixed instance policy (ansible-collections#232)
5533099 
* Fully support mixed instance policy

Previously, setting instances_distribution was not supported.
instances_distribution should be supported, to allow users to enable
spot instances within their mixed instance ASGs.

Note: The type and significance of the mixed_instance_policy has
changed. It now captures all of the mixed_instance_policy configuration
parameters, rather than just a list of instance types.

Fixes ansible-collections#231

* Restore mixed_instances_policy backwards-compat

Restore mixed_instances_policy backwards compatibility by using
mixed_instances_policy_full to return full dictionary.

Also, fix some doc typos, add CHANGELOG fragment, and split into
separate test case.

Addresses feedback in ansible-collections#232

* Only return mixed_instances_policy_full if set
danielcotton pushed a commit to danielcotton/community.aws that referenced this issue Nov 23, 2021
@JacobHenner @danielcotton
Fully support mixed instance policy (ansible-collections#232)
dda1bc8 
* Fully support mixed instance policy

Previously, setting instances_distribution was not supported.
instances_distribution should be supported, to allow users to enable
spot instances within their mixed instance ASGs.

Note: The type and significance of the mixed_instance_policy has
changed. It now captures all of the mixed_instance_policy configuration
parameters, rather than just a list of instance types.

Fixes ansible-collections#231

* Restore mixed_instances_policy backwards-compat

Restore mixed_instances_policy backwards compatibility by using
mixed_instances_policy_full to return full dictionary.

Also, fix some doc typos, add CHANGELOG fragment, and split into
separate test case.

Addresses feedback in ansible-collections#232

* Only return mixed_instances_policy_full if set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects_2.10 feature This issue/PR relates to a feature request has_pr module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fully support mixed instance policy JacobHenner/community.aws
3 participants
@JacobHenner @gravesm @ansibullbot