route53: always thinks alias record has changed

[geerlingguy]

SUMMARY

See: ansible/ansible#29858

Using command=create with the route53 module for an alias record without overwrite=yes fails when the record already exists. It correctly detects matching record if you are not using alias records.

The problem is the module accepts a domain without a trailing dot, e.g. www.example.com, but the route53_info module returns the domain with a trailing dot (e.g. www.example.com.), so it seems that's what Ansible is using for the comparison, thus causing the error.

ISSUE TYPE

• Bug Report

COMPONENT NAME

route53

ANSIBLE VERSION

2.9.12

CONFIGURATION

N/A

OS / ENVIRONMENT

macOS / Linux (all)

STEPS TO REPRODUCE

  - name: Create A record alias for proxy node
    route53:
      aws_access_key: "{{aws_access_key}}"
      aws_secret_key: "{{aws_secret_key}}"
      zone: "larkave.com"
      command: create
      type: A
      alias: True
      alias_hosted_zone_id: "{{ kube_proxy_zone_id }}"
      value: "{{ kube_proxy_dns_name }}"
      record: "proxy.{{ kube_dns_domain }}"
      ttl: 300

EXPECTED RESULTS

ok: [localhost]

ACTUAL RESULTS

fatal: [localhost]: FAILED! => {"changed": false, "failed": true, "invocation": {"module_args": {"alias": true, "alias_hosted_zone_id": "Z33MTJ483KN6FU", "aws_access_key": "AKIAJJU7TXWYTYP4GQAA", "aws_secret_key": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "command": "create", "ec2_url": null, "failover": null, "health_check": null, "hosted_zone_id": null, "identifier": null, "overwrite": null, "private_zone": false, "profile": null, "record": "proxy.larkave.com", "region": null, "retry_interval": 500, "security_token": null, "ttl": 300, "type": "A", "validate_certs": true, "value": "tst-kube-proxy-1257808881.us-west-2.elb.amazonaws.com", "vpc_id": null, "weight": null, "zone": "larkave.com"}, "module_name": "route53"}, "msg": "Record already exists with different value. Set 'overwrite' to replace it"}

Notes

From @petrosad's comment in the original issue:

To prevent the route53 module from always indicating that alias records have changed even when in fact they haven't, the following is required:

1. Lower-case the value of the alias record
2. Make sure the value ends in a dot
3. Make sure the value has no leading or trailing spaces
4. Make sure the alias_hosted_zone_id is all uppercase

Then this works exactly as expected. Without all of the above in place, the module will flag records as always changed.

[ansibullbot]

Files identified in the description:

• plugins/modules/route53.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @jillr @jimbydamonk @s-hertel @tremble @wimnat
click here for bot help

[tremble]

Thanks for copying this over @geerlingguy,

The Route53 module was rewritten to use the boto3 SDK (#405) and then had work done to fix the idempotency (#525). Looking at the integration tests this issue should now be resolved.