ec2_win_password returns changed state but doesn't change anything

[fd-davidtulloh]

SUMMARY

On success, ec2_win_password returns a changed state.

However it doesn't change anything.

changed: [pdc.services.hq.adct -> localhost] => {
    "changed": true,
    "invocation": {
        "module_args": {
            "aws_access_key": null,
            "aws_secret_key": null,
            "debug_botocore_endpoint_logs": false,
            "ec2_url": null,
            "instance_id": "i-0216d76aa054cd14d",
            "key_data": null,
            "key_file": "- cut -",
            "key_passphrase": null,
            "profile": null,
            "region": "ap-southeast-2",
            "security_token": null,
            "validate_certs": true,
            "wait": false,
            "wait_timeout": 120
        }
    },
    "win_password": "-cut-"
}

Happy to prepare a pull request to change this, code change is minor.

However this is backwards incompatible, changes existing behaviour.

[fd-davidtulloh]

workaround to produce what I believe is proper behaviour

  tasks:
    - ec2_win_password:
        instance_id: "{{ hostvars[inventory_hostname]['instance_id'] }}"
        key_file: "-cut-"
        region: ap-southeast-2
      delegate_to: localhost
      register: password
      changed_when: false
      failed_when: password.win_password == ""
    - set_fact: ansible_password="{{ password.win_password }}" #"
  vars:
    ansible_become: false

This is related to #142

[ansibullbot]

@fd-davidtulloh: Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.

Here are the items we could not find in your description:

• issue type
• ansible version
• component name

Please set the description of this issue with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/ISSUE_TEMPLATE/bug_report.md

click here for bot help

[nikhilpatne]

@fd-davidtulloh I can work on this issue.