Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecs_service plugin not updating the "placement_constraints" property #1414

Open
1 task done
anirudh-here-com opened this issue Aug 16, 2022 · 4 comments
Open
1 task done
Labels
bug This issue/PR relates to a bug has_pr module module plugins plugin (any type) python3 waiting_on_contributor Needs help. Feel free to engage to get things unblocked

Comments

@anirudh-here-com
Copy link

Summary

When I try to update "placement_constraints" property of an already existing service, its not getting reflected on the aws console.
However, it works perfectly fine when the service does not exist and needs to be created

Issue Type

Bug Report

Component Name

ecs_service

Ansible Version

ansible [core 2.13.2]
  config file = None
  configured module search path = ['/Users/asimha/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/Cellar/ansible/6.2.0/libexec/lib/python3.10/site-packages/ansible
  ansible collection location = /Users/asimha/.ansible/collections:/usr/share/ansible/collections
  executable location = /usr/local/bin/ansible
  python version = 3.10.6 (main, Aug 11 2022, 13:49:25) [Clang 13.1.6 (clang-1316.0.21.2.5)]
  jinja version = 3.1.2
  libyaml = True

Collection Versions

Collection    Version
------------- -------
amazon.aws    4.1.0  
community.aws 4.0.0  

AWS SDK versions

Name: boto3
Version: 1.24.45
Summary: The AWS SDK for Python
Home-page: https://github.com/boto/boto3
Author: Amazon Web Services
Author-email: 
License: Apache License 2.0
Location: /usr/local/lib/python3.10/site-packages
Requires: botocore, jmespath, s3transfer
Required-by: awswrangler, redshift-connector
---
Name: botocore
Version: 1.27.46
Summary: Low-level, data-driven core of boto 3.
Home-page: https://github.com/boto/botocore
Author: Amazon Web Services
Author-email: 
License: Apache License 2.0
Location: /usr/local/lib/python3.10/site-packages
Requires: jmespath, python-dateutil, urllib3
Required-by: aiobotocore, awswrangler, boto3, redshift-connector, s3transfer

Configuration

$ ansible-config dump --only-changed

OS / Environment

No response

Steps to Reproduce

Running the ansible playbook containing ecs_service block which has "placement_constraints" parameter defined

Expected Results

placement-constraints property should be set and visible in aws console.

Actual Results

placement-constraints property is not set in aws console

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module needs_triage plugins plugin (any type) python3 labels Aug 16, 2022
@superwesman
Copy link

The bug is easy to spot if you look at the call to update_servce compared to the call to create_service in ecs_service.py

response = service_mgr.update_service(module.params['name'],
                                      module.params['cluster'],
                                      module.params['task_definition'],
                                      module.params['desired_count'],
                                      deploymentConfiguration,
                                      network_configuration,
                                      module.params['health_check_grace_period_seconds'],
                                      module.params['force_new_deployment'])

response = service_mgr.create_service(module.params['name'],
                                      module.params['cluster'],
                                      module.params['task_definition'],
                                      loadBalancers,
                                      module.params['desired_count'],
                                      clientToken,
                                      role,
                                      deploymentConfiguration,
                                      module.params['placement_constraints'],
                                      module.params['placement_strategy'],
                                      module.params['health_check_grace_period_seconds'],
                                      network_configuration,
                                      serviceRegistries,
                                      module.params['launch_type'],
                                      module.params['platform_version'],
                                      module.params['scheduling_strategy']
                                      )

@markuman
Copy link
Member

good point!
The the work must be done here: https://github.com/ansible-collections/community.aws/blob/main/plugins/modules/ecs_service.py#L810-L831

does one of you (@anirudh-here-com @superwesman ) have some time to provide a PR to fix this issue?

softwarefactory-project-zuul bot pushed a commit that referenced this issue Jan 11, 2023
ecs_service supports constraints and strategy update

SUMMARY


ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ecs_service
ADDITIONAL INFORMATION


related issue #1414

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: 周丰 <[email protected]>
Reviewed-by: Alina Buzachis <None>
patchback bot pushed a commit that referenced this issue Jan 11, 2023
ecs_service supports constraints and strategy update

SUMMARY

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ecs_service
ADDITIONAL INFORMATION

related issue #1414

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: 周丰 <[email protected]>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 316f0ac)
patchback bot pushed a commit that referenced this issue Jan 11, 2023
ecs_service supports constraints and strategy update

SUMMARY

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ecs_service
ADDITIONAL INFORMATION

related issue #1414

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: 周丰 <[email protected]>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 316f0ac)
softwarefactory-project-zuul bot pushed a commit that referenced this issue Jan 12, 2023
[PR #1601/316f0acb backport][stable-5] ecs_service supports constraints and strategy update

This is a backport of PR #1601 as merged into main (316f0ac).
SUMMARY


ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ecs_service
ADDITIONAL INFORMATION


related issue #1414

Reviewed-by: Markus Bergholz <[email protected]>
softwarefactory-project-zuul bot pushed a commit that referenced this issue Jan 12, 2023
[PR #1601/316f0acb backport][stable-4] ecs_service supports constraints and strategy update

This is a backport of PR #1601 as merged into main (316f0ac).
SUMMARY


ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ecs_service
ADDITIONAL INFORMATION


related issue #1414

Reviewed-by: Markus Bergholz <[email protected]>
@alinabuzachis alinabuzachis added the waiting_on_contributor Needs help. Feel free to engage to get things unblocked label Feb 2, 2023
abikouo pushed a commit to abikouo/community.aws that referenced this issue Oct 24, 2023
fix link README

SUMMARY


Fixed links for scenario_guides.
ISSUE TYPE


Docs Pull Request

COMPONENT NAME


README.md

ADDITIONAL INFORMATION



N/A

related to ansible-collections#1743

Reviewed-by: Mark Chappell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug has_pr module module plugins plugin (any type) python3 waiting_on_contributor Needs help. Feel free to engage to get things unblocked
Projects
None yet
Development

No branches or pull requests

5 participants