Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capacity Provider Strategy for ECS Services #1137

Closed
1 task done
Tracked by #1142
fmgit00 opened this issue May 8, 2022 · 1 comment · Fixed by #1181
Closed
1 task done
Tracked by #1142

Capacity Provider Strategy for ECS Services #1137

fmgit00 opened this issue May 8, 2022 · 1 comment · Fixed by #1181
Labels
feature This issue/PR relates to a feature request needs_triage

Comments

@fmgit00
Copy link

fmgit00 commented May 8, 2022

Summary

Hi All,
the ecs_service module does not support the capacity provider strategy. The only possibility is to use the default strategy provider for the ECS cluster removing the launch_type parameter in the task definition for the module.

Please add this feature, is extremely important for the cluster autoscaler with EC2 instance.

Thank you.

https://docs.aws.amazon.com/cli/latest/reference/ecs/create-service.html

Option:
--capacity-provider-strategy (list)

The capacity provider strategy to use for the service.

If a capacityProviderStrategy is specified, the launchType parameter must be omitted. If no capacityProviderStrategy or launchType is specified, the defaultCapacityProviderStrategy for the cluster is used.

A capacity provider strategy may contain a maximum of 6 capacity providers.

Issue Type

Feature Idea

Component Name

community.aws.ecs_service

Additional Information



Code of Conduct


    

  •  I agree to follow the Ansible Code of Conduct
    • 


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
      



  

  @ansibullbot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          
Files identified in the description:

None


If these files are inaccurate, please update the component name section of the description or use the !component bot command.


click here for bot help


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @ansibullbot
ansibullbot




            added
      

  feature

  This issue/PR relates to a feature request

      

  needs_triage


  labels


      May 8, 2022

    

  



  

  

    
  


  

      

    @markuman
markuman



    mentioned this issue
    
      May 10, 2022
    





  


  

      
  
  Open

  





  
  

      
        
      
      

  
    
    
  


    10 tasks
  





  




  


  
    
  
  

    
  karcadia 

      added a commit
        to karcadia/community.aws
      that referenced
      this issue

    
      May 28, 2022
    
    

      


  

    

      


  

      
        @karcadia
  





      

        
          Capacity Provider Strategy for ECS Services ansible-collections#1137
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          7afd4ce
        
      

    

  

    

      
Add requested feature for capacity provider strategy.

Capacity Provider Strategy is mutually exclusive with launch_type and a given service cannot be changed from one to the other.

Possibly still needs:
Camel <=> Snake casing for the subelements of capacity_provider_strategy.

Catch if provided list has more than 6 elements and fail cleanly.

    




    

  




  

  

    
  


  

      

    @karcadia
karcadia



    mentioned this issue
    
      May 30, 2022
    





  


  

      
   Merged

  







  




  


  
    
  
  

    
  karcadia 

      added a commit
        to karcadia/community.aws
      that referenced
      this issue

    
      May 30, 2022
    
    

      


  

    

      


  

      
        @karcadia
  





      

        
          Capacity Provider Strategy for ECS Services ansible-collections#1137
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          097b2b3
        
      

    

  

    

      
Add requested feature for capacity provider strategy.

Capacity Provider Strategy is mutually exclusive with launch_type and a given service cannot be changed from one to the other.

Possibly still needs:
Camel <=> Snake casing for the subelements of capacity_provider_strategy.

Catch if provided list has more than 6 elements and fail cleanly.

    




    

  




    

    


  


  
    
  
  

    
  softwarefactory-project-zuul bot

      pushed a commit
      that referenced
      this issue

    
      Jun 2, 2022
    
    

      


  

    

      


  

      
        @karcadia
  





      

        
          ecs_service -- Capacity provider strategy (#1181)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          8a5ed47
        
      

    

  

    

      
ecs_service -- Capacity provider strategy

SUMMARY
Fixes #1137
Per request, allow for the user to provide a capacity_provider_strategy when creating or updating an ECS service. This capacity_provider_strategy is a list of 1-6 dictionaries. The new capacity_provider_strategy is mutually exclusive with launch_type and an existing service cannot be changed from one to the other.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ecs_service
ADDITIONAL INFORMATION
The new parameter is optional and non-default. If neither launch_type or capacity_provider_strategy are provided, the new service will default to EC2 launch_type. The module handles the mutually exclusivity and also catches and fails cleanly when trying to change an existing service from launch_type to capacity_provider_strategy or vice versa.
Tested pretty thoroughly against ansible 2.9.27. Updated parameters, examples, and return objects provided.
Before merge the module will just ignore the capacity_provider_strategy and default to EC2 launch_type.
After merge the module will handle either launch_type or capacity_provider_strategy and create/update the service as necessary.
- community.aws.ecs_service:
    state: present
    name: test-service
    cluster: test-cluster
    task_definition: test-task-definition
    desired_count: 1
    capacity_provider_strategy:
      - capacity_provider: test-capacity-provider-1
        weight: 1
        base: 0

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>

    




    

  




  


  
    
  
  

    
  abikouo 

      pushed a commit
        to abikouo/community.aws
      that referenced
      this issue

    
      Oct 24, 2023
    
    

      


  

    

      


  

      
        @GomathiselviS
  





      

        
          S3_bucket : Handle setting of permissions while acl is disabled (ansi…
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          86b20e9
        
      

    

  

    

      
…ble-collections#1168)

S3_bucket : Handle setting of permissions while acl is disabled

SUMMARY


As per boto3 aws documentation
When ObjectOwnership is BucketOwnerEnforced - Access control lists (ACLs) are disabled and no longer affect permissions.
Fixes ansible-collections#1137
ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Jill R <None>
Reviewed-by: Gonéri Le Bouder <[email protected]>
Reviewed-by: GomathiselviS <None>
Reviewed-by: Mark Chappell <None>

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    feature

  This issue/PR relates to a feature request
  

    needs_triage









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




          
  
Successfully merging a pull request may close this issue.





    


  
          
      ecs_service -- Capacity provider strategy

    
      karcadia/community.aws
    





    
  




      

    

  
      

  

    

      2 participants
    

    

        
          @ansibullbot 
        
          @fmgit00