Refactor s3_bucket_notifications to support SNS / SQS (#940)

Refactor s3_bucket_notifications to support SNS / SQS SUMMARY Refactor s3_bucket_notifications to extend module to support the extra targets of SNS and SQS along with the currently supported Lambda functions. Summary of changes: Refactor module to support SNS/SQS targets along with current Lambda function support. Fix check mode coverage Update integration tests to more comprehensive cover functionality. Update documentation in sns_topic and sqs_queue modules to add policy setting example. Fixes: #140 ISSUE TYPE Feature Pull Request COMPONENT NAME s3_bucket_notifications ADDITIONAL INFORMATION https://boto3.amazonaws.com/v1/documentation/api/1.16.0/reference/services/s3.html#S3.Client.put_bucket_notification_configuration Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Markus Bergholz <[email protected]>
ansible-collections · Mar 28, 2022 · dd89ed1 · dd89ed1
1 parent 58b3c68
commit dd89ed1
Show file tree

Hide file tree

Showing 9 changed files with 979 additions and 438 deletions.
diff --git a/changelogs/fragments/940-refactor-s3_bucket_notifications.yml b/changelogs/fragments/940-refactor-s3_bucket_notifications.yml
@@ -0,0 +1,2 @@
+major_changes:
+  - s3_bucket_notifications - refactor module to support SNS / SQS targets as well as the existing support for Lambda functions (https://github.com/ansible-collections/community.aws/issues/140).
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		major_changes:
		- s3_bucket_notifications - refactor module to support SNS / SQS targets as well as the existing support for Lambda functions (https://github.com/ansible-collections/community.aws/issues/140).