-
Notifications
You must be signed in to change notification settings - Fork 398
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
s3_sync - Improve error handling when testing for existing files (#1330…
…) (#1335) [PR #1330/40984a40 backport][stable-4] s3_sync - Improve error handling when testing for existing files This is a backport of PR #1330 as merged into main (40984a4). SUMMARY fixes: #58 Simplifies handling of '404' codes (use is_boto3_error_code) Assume 403 files need updating (it's the best we can do, and mimics aws cli) Allows Boto3 exceptions to fall through to the outer try/except clause and cleanly fail rather than rethrowing it as an Exception() ISSUE TYPE Feature Pull Request COMPONENT NAME s3_sync ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
- Loading branch information
1 parent
7b447cf
commit b02c322
Showing
3 changed files
with
17 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
minor_changes: | ||
- s3_sync - improves error handling during ``HEAD`` operation to compare existing files (https://github.com/ansible-collections/community.aws/issues/58). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters