Skip to content

Commit

Permalink
* Address reviewer comments
Browse files Browse the repository at this point in the history
  • Loading branch information
alinabuzachis committed Mar 2, 2021
1 parent 75b7abf commit ac19245
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion plugins/modules/ec2_vpc_nat_gateway.py
Original file line number Diff line number Diff line change
Expand Up @@ -951,7 +951,7 @@ def ensure_tags(client, module, nat_gw_id, tags, purge_tags, check_mode):
changed = False

if check_mode and nat_gw_id is None:
# We can't describe tags without an option id, we might get here when creating a new option set in check_mode
# We can't describe tags without an EIP id, we might get here when creating a new EIP in check_mode
return final_tags, changed

filters = ansible_dict_to_boto3_filter_list({'resource-id': nat_gw_id, 'resource-type': 'natgateway'})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
- amazon.aws

block:

# ============================================================
- name: Create a VPC
ec2_vpc_net:
Expand Down Expand Up @@ -185,7 +186,6 @@
vars:
first_ngw: '{{ avalaible_ngws.result[0] }}'


# ============================================================
- name: Trying this again for idempotency - create new NAT gateway with eip allocation-id - CHECK_MODE
ec2_vpc_nat_gateway:
Expand Down

0 comments on commit ac19245

Please sign in to comment.