Skip to content

Commit

Permalink
Add a fake integration suite including an aliases file listing every …
Browse files Browse the repository at this point in the history
…module name with missing integration tests. (#986) (#1010)

Add a fake integration suite including an aliases file listing every …

…module name with missing integration tests. (#986)
Prevent CI to be run for whole collection when modules without integration tests are modified
Add a fake integration suite including an aliases file listing every module name with missing integration tests.
This fake suite is necessary for the new CI ansible-test-splitter behaviour. Namely, if one of the modules (listed in the aliases file) without a test suite is modified, the CI is run for the entire collection since the ansible-test-splitter won't find any target match. This fake integration suite helps handle this situation by avoiding running the CI for the whole collection. Furthermore, since the modules listed in the aliases file are marked as disabled, tests are automatically skipped).
Add some of the modules in the aliases files where it makes more sense.
SUMMARY
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Mark Chappell 
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Woolley <[email protected]>
  • Loading branch information
alinabuzachis authored Mar 24, 2022
1 parent 00a26e9 commit 9b990b9
Show file tree
Hide file tree
Showing 6 changed files with 53 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tests/integration/targets/aws_waf_web_acl/aliases
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,5 @@ aws_waf_info
aws_waf_web_acl
aws_waf_web_match
aws_waf_web_rule
aws_waf_condition
aws_waf_rule
2 changes: 2 additions & 0 deletions tests/integration/targets/ec2_asg/aliases
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@
disabled

cloud/aws

ec2_asg_info
1 change: 1 addition & 0 deletions tests/integration/targets/ecs_cluster/aliases
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ unsupported

cloud/aws

ecs_service
ecs_service_info
ecs_task
ecs_taskdefinition
Expand Down
2 changes: 2 additions & 0 deletions tests/integration/targets/elb_instance/aliases
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
cloud/aws

elb_classic_lb_info
5 changes: 5 additions & 0 deletions tests/integration/targets/legacy_missing_tests/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
## Fake integration suite

This is a fake integration suite including an aliases file listing every module name with missing integration tests.

This fake suite is necessary for the new CI ansible-test-splitter behaviour. Namely, if one of the modules (listed in the aliases file) without a test suite is modified, the CI is run for the entire collection since the ansible-test-splitter won't find any target match. This fake integration suite helps handle this situation by avoiding running the CI for the whole collection. Furthermore, since the modules listed in the aliases file are marked as disabled, tests are automatically skipped).
41 changes: 41 additions & 0 deletions tests/integration/targets/legacy_missing_tests/aliases
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
disabled

# Modules that do not have test suites
aws_application_scaling_policy
aws_batch_compute_environment
aws_batch_job_definition
aws_batch_job_queue
aws_direct_connect_confirm_connection
aws_direct_connect_connection
aws_direct_connect_gateway
aws_direct_connect_link_aggregation_group
aws_direct_connect_virtual_interface
aws_s3_cors
aws_sgw_info
cloudfront_info
cloudfront_invalidation
cloudfront_origin_access_identity
cloudwatchevent_rule
cloudwatchlogs_log_group_info
data_pipeline
dynamodb_ttl
ec2_ami_copy
ec2_asg_lifecycle_hook
ec2_customer_gateway
ec2_customer_gateway_info
ec2_snapshot_copy
ec2_vpc_vgw_info
ec2_win_password
ecs_attribute
elasticache_info
elasticache_parameter_group
elasticache_snapshot
elb_target_group_info
iam_mfa_device_info
lambda_event
rds_instance_snapshot
rds_snapshot_info
redshift_cross_region_snapshots
s3_website
sts_session_token
ec2_vpc_vpn

0 comments on commit 9b990b9

Please sign in to comment.