Skip to content

Commit

Permalink
feat: add larger instance types for MSK cluster (#1947)
Browse files Browse the repository at this point in the history
feat: add larger instance types for MSK cluster

This commit adds support for larger instance types (kafka.m5.8xlarge, kafka.m5.12xlarge, kafka.m5.16xlarge, kafka.m5.24xlarge) to the MSK cluster module.
Now users can choose from a wider range of instance sizes when creating an MSK cluster.
If the provisioning MSK supports m6 and m7 in the future, may want to consider removing the choice syntax.
(Provisioning M5 types are not expected to be added anymore, The m5 has a maximum of 24 xlarge types.
SUMMARY


Fixes #1946
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

msk_cluster
ADDITIONAL INFORMATION


Link to MSK Provisioning Instance Types documentation

https://docs.aws.amazon.com/msk/latest/developerguide/msk-create-cluster.html#broker-instance-types

Reviewed-by: Alina Buzachis
Reviewed-by: JIHUN KIM <[email protected]>
Reviewed-by: Mark Chappell
  • Loading branch information
shblue21 authored Jan 11, 2024
1 parent 4c5cb40 commit 2b5d71d
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 0 deletions.
2 changes: 2 additions & 0 deletions changelogs/fragments/1947-add_support_msk_addtinal_type.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
minor_changes:
- msk_cluster - Support for additional ``m5`` and ``m7g`` types of MSK clusters (https://github.com/ansible-collections/community.aws/pull/1947).
22 changes: 22 additions & 0 deletions plugins/modules/msk_cluster.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,17 @@
- kafka.m5.xlarge
- kafka.m5.2xlarge
- kafka.m5.4xlarge
- kafka.m5.8xlarge
- kafka.m5.12xlarge
- kafka.m5.16xlarge
- kafka.m5.24xlarge
- kafka.m7g.large
- kafka.m7g.xlarge
- kafka.m7g.2xlarge
- kafka.m7g.4xlarge
- kafka.m7g.8xlarge
- kafka.m7g.12xlarge
- kafka.m7g.16xlarge
default: kafka.t3.small
type: str
ebs_volume_size:
Expand Down Expand Up @@ -662,6 +673,17 @@ def main():
"kafka.m5.xlarge",
"kafka.m5.2xlarge",
"kafka.m5.4xlarge",
"kafka.m5.8xlarge",
"kafka.m5.12xlarge",
"kafka.m5.16xlarge",
"kafka.m5.24xlarge",
"kafka.m7g.large",
"kafka.m7g.xlarge",
"kafka.m7g.2xlarge",
"kafka.m7g.4xlarge",
"kafka.m7g.8xlarge",
"kafka.m7g.12xlarge",
"kafka.m7g.16xlarge",
],
default="kafka.t3.small",
),
Expand Down

0 comments on commit 2b5d71d

Please sign in to comment.