Skip to content

Commit

Permalink
minor cloudfront_* sanity updates
Browse files Browse the repository at this point in the history
  • Loading branch information
abikouo committed Nov 21, 2022
1 parent 625f7d4 commit 110a926
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 7 deletions.
4 changes: 2 additions & 2 deletions plugins/modules/cloudfront_origin_access_identity.py
Original file line number Diff line number Diff line change
Expand Up @@ -199,11 +199,11 @@ def __init__(self, module):
def describe_origin_access_identity(self, origin_access_identity_id, fail_if_missing=True):
try:
return self.__cloudfront_facts_mgr.get_origin_access_identity(id=origin_access_identity_id, fail_if_error=False)
except is_boto3_error_code('NoSuchCloudFrontOriginAccessIdentity') as e:
except is_boto3_error_code('NoSuchCloudFrontOriginAccessIdentity') as e: # pylint: disable=duplicate-except
if fail_if_missing:
self.module.fail_json_aws(e, msg="Error getting etag from origin_access_identity.")
return {}
except (ClientError, BotoCoreError) as e:
except (ClientError, BotoCoreError) as e: # pylint: disable=duplicate-except
self.module.fail_json_aws(e, msg="Error getting etag from origin_access_identity.")

def validate_etag_from_origin_access_identity_id(self, origin_access_identity_id, fail_if_missing):
Expand Down
1 change: 0 additions & 1 deletion tests/sanity/ignore-2.11.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
plugins/modules/cloudfront_distribution_info.py pylint:unnecessary-comprehension # (new test) Should be an easy fix, but testing is a challenge - test are broken and aliases require a wildcard cert in ACM
plugins/modules/codebuild_project.py pylint:collection-deprecated-version # https://github.com/ansible-collections/community.aws/issues/1546
1 change: 0 additions & 1 deletion tests/sanity/ignore-2.12.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
plugins/modules/cloudfront_distribution_info.py pylint:unnecessary-comprehension # (new test) Should be an easy fix, but testing is a challenge - test are broken and aliases require a wildcard cert in ACM
plugins/modules/codebuild_project.py pylint:collection-deprecated-version # https://github.com/ansible-collections/community.aws/issues/1546
1 change: 0 additions & 1 deletion tests/sanity/ignore-2.13.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
plugins/modules/cloudfront_distribution_info.py pylint:unnecessary-comprehension # (new test) Should be an easy fix, but testing is a challenge - test are broken and aliases require a wildcard cert in ACM
plugins/modules/codebuild_project.py pylint:collection-deprecated-version # https://github.com/ansible-collections/community.aws/issues/1546
1 change: 0 additions & 1 deletion tests/sanity/ignore-2.14.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
plugins/modules/cloudfront_distribution_info.py pylint:unnecessary-comprehension # (new test) Should be an easy fix, but testing is a challenge - test are broken and aliases require a wildcard cert in ACM
plugins/modules/codebuild_project.py pylint:collection-deprecated-version # https://github.com/ansible-collections/community.aws/issues/1546
1 change: 0 additions & 1 deletion tests/sanity/ignore-2.15.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
plugins/modules/cloudfront_distribution_info.py pylint:unnecessary-comprehension # (new test) Should be an easy fix, but testing is a challenge - test are broken and aliases require a wildcard cert in ACM
plugins/modules/codebuild_project.py pylint:collection-deprecated-version # https://github.com/ansible-collections/community.aws/issues/1546

0 comments on commit 110a926

Please sign in to comment.