Skip to content

Commit

Permalink
small steps
Browse files Browse the repository at this point in the history
  • Loading branch information
markuman committed Dec 1, 2023
1 parent 55f63ae commit 0ffa3dd
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 13 deletions.
20 changes: 10 additions & 10 deletions tests/integration/targets/autoscaling_policy/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@

- assert:
that:
- result.policy_name == "{{ resource_prefix }}_simplescaling_policy"
- result.policy_name == resource_prefix ~ '_simplescaling_policy'
- result.changed

- name: Update Simple Scaling policy using explicit defaults
Expand All @@ -61,7 +61,7 @@

- assert:
that:
- result.policy_name == "{{ resource_prefix }}_simplescaling_policy"
- result.policy_name == resource_prefix ~ '_simplescaling_policy'
- not result.changed

- name: min_adjustment_step is ignored with ChangeInCapacity
Expand All @@ -77,7 +77,7 @@

- assert:
that:
- result.policy_name == "{{ resource_prefix }}_simplescaling_policy"
- result.policy_name == resource_prefix ~ '_simplescaling_policy'
- not result.changed
- result.adjustment_type == "ChangeInCapacity"

Expand All @@ -94,7 +94,7 @@

- assert:
that:
- result.policy_name == "{{ resource_prefix }}_simplescaling_policy"
- result.policy_name == resource_prefix ~ '_simplescaling_policy'
- result.changed
- result.adjustment_type == "PercentChangeInCapacity"

Expand Down Expand Up @@ -126,7 +126,7 @@

- assert:
that:
- result.policy_name == "{{ resource_prefix }}_stepscaling_policy"
- result.policy_name == resource_prefix ~ '_stepscaling_policy'
- result.changed

- name: Add another step
Expand All @@ -149,7 +149,7 @@

- assert:
that:
- result.policy_name == "{{ resource_prefix }}_stepscaling_policy"
- result.policy_name == resource_prefix ~ '_stepscaling_policy'
- result.changed
- result.adjustment_type == "PercentChangeInCapacity"

Expand Down Expand Up @@ -189,7 +189,7 @@

- assert:
that:
- result.policy_name == "{{ resource_prefix }}_targettracking_predefined_policy"
- result.policy_name == resource_prefix ~ '_targettracking_predefined_policy'
- result.changed
- result is successful

Expand All @@ -206,7 +206,7 @@

- assert:
that:
- result.policy_name == "{{ resource_prefix }}_targettracking_predefined_policy"
- result.policy_name == resource_prefix ~ '_targettracking_predefined_policy'
- result is not changed

# # It would be good to also test this but we would need an Target group and an ALB
Expand Down Expand Up @@ -263,7 +263,7 @@

- assert:
that:
- result.policy_name == "{{ resource_prefix }}_targettracking_custom_policy"
- result.policy_name == resource_prefix ~ '_targettracking_custom_policy'
- result.changed
- result is successful

Expand All @@ -285,7 +285,7 @@

- assert:
that:
- result.policy_name == "{{ resource_prefix }}_targettracking_custom_policy"
- result.policy_name == resource_prefix ~ '_targettracking_custom_policy'
- result is not changed

always:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
that:
- create_result is changed
- create_result is not failed
- create_result.response_headers_policy.response_headers_policy_config.name == "{{ resource_prefix }}-my-header-policy"
- create_result.response_headers_policy.response_headers_policy_config.name == resource_prefix ~ '-my-header-policy'

- name: Rerun same task to ensure idempotence
cloudfront_response_headers_policy:
Expand Down
4 changes: 2 additions & 2 deletions tests/integration/targets/elasticache/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@
that:
- elasticache_redis is changed
- elasticache_redis.elasticache.data is defined
- elasticache_redis.elasticache.name == "{{ elasticache_redis_test_name }}"
- elasticache_redis.elasticache.data.CacheSubnetGroupName == "{{ elasticache_subnet_group_name }}"
- elasticache_redis.elasticache.name == elasticache_redis_test_name
- elasticache_redis.elasticache.data.CacheSubnetGroupName == elasticache_subnet_group_name

- name: Add security group for Redis access in Elasticache
ec2_security_group:
Expand Down

0 comments on commit 0ffa3dd

Please sign in to comment.