Allow nested_type terraform attributes

[justinc1]

SUMMARY

terraform providers schema -json attributes can be nested. In this case, there is no type field, but we have nested_type.

The collection uses schema to sanitize diff in terraform module output.
If attribute is sensitive, its value will be hidden.

In case of nested attribute it might be possible to have top level attribute with sensitive=False containing a child attribute with sensitive=True. But I was not able to find terraform provider with such schema. I looked only at 35 official providers, and ignored remaining ~3000 partner and community providers.

The only official provider with nested_type attributes and also sensitive=True child was waypoint. A schema fragment is included into unit tests. git_auth_basic has non-sensitive username and sensitive password. Also git_auth_basic is marked as sensitive. Thus it seems it is not needed to modify logic for diff sanitization - whole git_auth_basic will be hidden.

Fixes #93

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

cloud.terraform.terraform

ADDITIONAL INFORMATION

Terraform provider awscc schema also contains nested attributes, an integration test is added to check schema is parsed.

EDIT:

terraform providers schema -json | jq '.provider_schemas["registry.terraform.io/terraform-redhat/rhcs"].resource_schemas.rhcs_cluster_rosa_classic.block.attributes.admin_credentials'

This is example of nested_type attribute that is not marked as sensitive, but it does contain sensitive sub-attribute.
Maybe a follow up PR will be need to ensure admin_credentials.password is hidden in ansible diff output.

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/04ab663fbb7346438a49a50fccd3f339

✔️ ansible-galaxy-importer SUCCESS in 4m 42s
✔️ build-ansible-collection SUCCESS in 7m 30s

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c52bf2) 73.00% compared to head (45dc3b4) 74.10%.
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   73.00%   74.10%   +1.09%     
==========================================
  Files          16       17       +1     
  Lines        1015     1058      +43     
  Branches      182      186       +4     
==========================================
+ Hits          741      784      +43     
  Misses        243      243              
  Partials       31       31              

Flag	Coverage Δ
sanity	?
units	74.10% <ø> (+1.49%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/2d7467228ab44ddd9aca32ea125750d9

❌ ansible-galaxy-importer RETRY_LIMIT in 7m 04s
✔️ build-ansible-collection SUCCESS in 13m 26s

[softwarefactory-project-zuul]

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/cloud.terraform for 101,14a2d5c27d883c76d710ce0ca060d7facfa3277c

[abikouo]

@justinc1 you need to rebase the PR to fix linters issue (especially the isort one on tests/unit/plugins/modules/test_terraform.py)

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4209255e26e3477181ddc5439913b0a9

✔️ ansible-galaxy-importer SUCCESS in 4m 40s
✔️ build-ansible-collection SUCCESS in 7m 33s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/28a461e1d72949fab50693cfa39e8f74

✔️ ansible-galaxy-importer SUCCESS in 4m 54s
✔️ build-ansible-collection SUCCESS in 7m 27s

[abikouo]

LGTM! Thanks @justinc1

[alinabuzachis]

@justinc1 Thank you for working on this! LGTM!