Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception handler for loop #67

Merged
merged 2 commits into from
Jul 14, 2021

Conversation

gravesm
Copy link
Member

@gravesm gravesm commented Jun 29, 2021

SUMMARY

The async loop had no exception handler attached besides the default.
This would cause the server to hang when an unhandled exception
occurred.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

gravesm added 2 commits June 29, 2021 11:39
The async loop had no exception handler attached besides the default.
This would cause the server to hang when an unhandled exception
occurred.
@gravesm gravesm requested a review from goneri June 29, 2021 16:28
@goneri goneri added the gate label Jun 29, 2021
@pabelanger
Copy link

recheck

@goneri goneri closed this Jul 1, 2021
@goneri goneri reopened this Jul 1, 2021
@goneri goneri added gate and removed gate labels Jul 14, 2021
@ansible-zuul ansible-zuul bot merged commit bf29a13 into ansible-collections:main Jul 14, 2021
@gravesm gravesm deleted the exceptions branch July 14, 2021 18:43
goneri added a commit to goneri/cloud.common that referenced this pull request Jul 29, 2021
Major Changes
-------------

- turbo - enable turbo mode for lookup plugins

Bugfixes
--------

- add exception handler to main async loop (ansible-collections#67).
- pass current task's environment through to execution (ansible-collections#69).
- turbo - AnsibleTurboModule was missing some _ansible_facts variable like _diff, _ansible_tmpdir. (ansible-collections#65)
- turbo - honor the ``remote_tmp`` configuration key.
@goneri goneri mentioned this pull request Jul 29, 2021
ansible-zuul bot pushed a commit that referenced this pull request Jul 29, 2021
prepare 2.0.4 release

Major Changes

turbo - enable turbo mode for lookup plugins

Bugfixes

add exception handler to main async loop (#67).
pass current task's environment through to execution (#69).
turbo - AnsibleTurboModule was missing some _ansible_facts variable like _diff, _ansible_tmpdir. (#65)
turbo - honor the remote_tmp configuration key.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants