Make test_start_daemon_with_no_mock less flaky #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`test_start_daemon_with_no_mock` could be flaky on slow architectures (observed on Debian riscv64), since it races with the startup of its test server process. Make it more tolerant.
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 12s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
test_start_daemon_with_no_mockcould be flaky on slow architectures (observed on Debian riscv64), since it races with the startup of its test server process. Make it more tolerant.ISSUE TYPE
COMPONENT NAME
tests