fix cliconf for IOS XRd #510
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmussmann
force-pushed
the
issue/509
branch
from
3b979d9
to
376cb54
Compare
jmussmann
force-pushed
the
issue/509
branch
from
376cb54
to
7c7e9ee
Compare
|
@jmussmann can you please add relevant tests to vaildate the change? |
jmussmann
force-pushed
the
issue/509
branch
from
e034efb
to
71e23b0
Compare
|
@Ruchip16 thank you for the hint. I added the tests. |
|
@Ruchip16 would it be possible to merge this fix, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The collection does not work with IOS XRd and cliconf.
This PR fixes #509 to allow connections to IOS XRd with cliconf.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
The problem is, that IOS XRd does not support the "show inventory" command.
As a solution, I set the output to an empty string if the command fails.