Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requirements: remove google dependency #292

Merged
merged 1 commit into from
Nov 3, 2022
Merged

requirements: remove google dependency #292

merged 1 commit into from
Nov 3, 2022

Conversation

dsavineau
Copy link
Contributor

SUMMARY

The google dependency has been added in a8ba926 but is never uses by this collection.
Moreover, the PyPi google library provides the googlesearch module [1] while the commit introducing the change was only about grpc connection via the protobuf library (which provides the google.protobuf module).

[1] https://pypi.org/project/google

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

requirements

@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 00s
✔️ build-ansible-collection SUCCESS in 4m 19s
✔️ ansible-tox-linters SUCCESS in 5m 46s

@dsavineau
requirements: remove google dependency
0be5531 
The google dependency has been added in a8ba926 but is never uses by
this collection.
Moreover, the PyPi google library provides the googlesearch module [1] while
the commit introducing the change was only about grpc connection via the
protobuf library (which provides the google.protobuf module).

[1] https://pypi.org/project/google

Signed-off-by: Dimitri Savineau <[email protected]>
@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 48s
✔️ build-ansible-collection SUCCESS in 7m 06s
✔️ ansible-tox-linters SUCCESS in 5m 23s

@ashwini-mhatre
Copy link
Contributor

This requirement is added in #143

@dsavineau
Copy link
Contributor Author

This requirement is added in #143

That's exactly what I mentioned in the commit message.
But my point is that this dependency isn't use at all in the code since the plugins/sub_plugins/grpc/pb/ems_grpc_pb2.py file only uses google.protobuf which isn't provided via the google pypi module.

@trishnaguha trishnaguha reopened this Nov 2, 2022
@ashwini-mhatre
Copy link
Contributor

This requirement is added in #143

That's exactly what I mentioned in the commit message. But my point is that this dependency isn't use at all in the code since the plugins/sub_plugins/grpc/pb/ems_grpc_pb2.py file only uses google.protobuf which isn't provided via the google pypi module.

I missed issue's description.+1 from myside

@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 39s
✔️ build-ansible-collection SUCCESS in 3m 54s
✔️ ansible-tox-linters SUCCESS in 5m 12s

@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 3m 51s
✔️ build-ansible-collection SUCCESS in 3m 55s
✔️ ansible-tox-linters SUCCESS in 5m 13s

@softwarefactory-project-zuul
Copy link

Pull request merge failed: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information.

@ashwini-mhatre ashwini-mhatre merged commit f0078be into ansible-collections:main Nov 3, 2022
@dsavineau dsavineau deleted the remove_google_requirement branch November 3, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

@ashwini-mhatre ashwini-mhatre ashwini-mhatre approved these changes

Assignees
No one assigned
Labels
mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsavineau @ashwini-mhatre @trishnaguha