-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New modules for webapp vnet connection #590
New modules for webapp vnet connection #590
Conversation
@Fred-sun Hello, this is now ready for review. Can you please take a look and advise when you are able? |
@l3ender Please add use cases related to the azure_rm_webapp_vnetconnection_info.py module in tests/integration/targets/azure_rm_webapp_vnetconnection/tasks/main.yml, thank you! |
@l3ender You are advised to change the module name to --azure_rm_webappvnetconnnection. to ensure that the module name is consistent with other modules. Thank you very much! |
Co-authored-by: Fred-sun <[email protected]>
…tion' into webapp-vnet-integration
@Fred-sun Thank you for the review. I have updated--please let me know if there are other changes! If can you provide a python linting file which can be used for style/formatting it would be helpful! |
Co-authored-by: Fred-sun <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@l3ender ansible core new request! Thank you very much!
@l3ender can you resolve the file conflicting files |
@xuzhang3 Merge conflict resolved...thanks! |
LGTM |
@l3ender We are preparing the new release, we still have several tasks to do before the new version. |
SUMMARY
This PR includes new modules to accomplish ability to configure a webapp's vnet connection (integration), so that networking configuration can be defined for a web app.
Resolves #556.
ISSUE TYPE
COMPONENT NAME
azure_rm_webappvnetconnection
azure_rm_webappvnetconnection_info
ADDITIONAL INFORMATION
Output for a connection looks like: