New module: azure_rm_ddosprotectionplan #493

ikarldasan · 2021-04-16T14:47:26Z

SUMMARY

This module introduces a wide variety of configurations for creating a DDoS protection plan on Azure.
Create DDoS protection plan on Azure.
Update DDoS protection plan on Azure.
Delete DDoS protection plan on Azure.
Get DDoS protection plan on Azure.
List DDoS protection plan in Azure Resource Group.
List DDoS protection plan in Azure Subscription.

Fixes #492

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

azure_rm_ddos_protection_plan

ADDITIONAL INFORMATION

This module allows user to create/update or delete the DDoS Protection Plan.
It also provides all the parameters given by: https://docs.microsoft.com/en-us/azure/ddos-protection/ddos-protection-overview

More information

azure_rm_ddos_protection_plan:
   name: ddos
   resource_group: testgroupans
   location: eastus2
   tags:
      a: c

Fred-sun · 2021-04-19T06:27:34Z

@ikarldasan Thank for your contribution! Please help to change the module name to azure_rm_ddosprotectionplan*, which is consistent with other modules, thank you!

Fred-sun

@ikarldasan There is no content in " tests/integration/targets/azure_rm_ddos_protection_plan/aliases"! Please share the result of you execute "tests/integration/targets/azure_rm_ddos_protection_plan/tasks/main.yml"!

cloud/azure
shippable/azure/group10
destructive

Fred-sun · 2021-04-19T10:01:13Z

plugins/modules/azure_rm_ddos_protection_plan.py

+          - absent
+          - present
+extends_documentation_fragment:
+- azure.azcollection.azure


Suggested change

- azure.azcollection.azure

- azure.azcollection.azure

- azure.azcollection.azure_tags

Fred-sun · 2021-04-19T10:02:52Z

plugins/modules/azure_rm_ddos_protection_plan.py

+      default: present
+      choices:
+          - absent
+          - present


Please add log_path and log_mode parameter to this module! Thank you very much!

log_path: description: - parent argument. type: str log_mode: description: - parent argument. type: str

ikarldasan · 2021-04-20T04:11:41Z

@ikarldasan There is no content in " tests/integration/targets/azure_rm_ddos_protection_plan/aliases"! Please share the result of you execute "tests/integration/targets/azure_rm_ddos_protection_plan/tasks/main.yml"!
cloud/azure
shippable/azure/group10
destructive

@Fred-sun , have addressed the changes suggested.
But facing an issue running the integration tests.
Running this command and getting the following result.

ansible-test integration azure_rm_ddosprotectionplan --allow-destructive -e -vvv

RLIMIT_NOFILE: (1024, 1048576)
MAXFD: -1
Falling back to tests in "tests/integration/targets/" because "roles/test/" was not found.
WARNING: Excluding tests marked "cloud/azure" which require config (see "/home/karl/.local/lib/python3.8/site-packages/ansible_test/config/cloud-config-azure.ini.template"): azure_rm_ddosprotectionplan
WARNING: All targets skipped.

Can you please help understand what I may be missing.
Thank you!!

ikarldasan · 2021-04-20T15:43:58Z

@Fred-sun here are the test results, run locally. Running the integration test as playbooks using ansible-playbook playbook -vvv. Thank you.

Create:

**Playbook**
---
    - hosts: localhost
      connection: local
      tasks:   
       - name: Create DDoS protection plan
         azure.azcollection.azure_rm_ddosprotectionplan:
           client_id: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           resource_group: rg
           secret: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           subscription_id: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           tenant: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           location: eastus2
           name: ddos
         register: results

**Result:**

changed: [localhost] => {
    "changed": true,
    "check_mode": false,
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "api_profile": "latest",
            "append_tags": true,
            "auth_source": null,
            "cert_validation_mode": null,
            "client_id": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "cloud_environment": "AzureCloud",
            "location": "eastus2",
            "log_mode": null,
            "log_path": null,
            "name": "ddos",
            "password": null,
            "profile": null,
            "resource_group": "rg",
            "secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "state": "present",
            "subscription_id": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
            "tags": null,
            "tenant": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER"
        }
    },
    "state": {
        "additional_properties": null,
        "etag": "W/\"\"",
        "id": "/subscriptions/XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX/resourceGroups/rg/providers/Microsoft.Network/ddosProtectionPlans/ddos",
        "location": "eastus2",
        "name": "ddos",
        "provisioning_state": "Succeeded",
        "resource_guid": null,
        "tags": null,
        "type": "Microsoft.Network/ddosProtectionPlans",
        "virtual_networks": null
    }
}
META: ran handlers
META: ran handlers

PLAY RECAP *************************************************************************************************************************************************************************************************
localhost                  : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

Create (check mode):

**Playbook:**
---
    - hosts: localhost
      connection: local
      tasks:   
       - name: Create DDoS protection plan (check mode)
         azure.azcollection.azure_rm_ddosprotectionplan:
           client_id: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           resource_group: rg
           secret: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           subscription_id: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           tenant: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           location: eastus2
           name: ddos
         register: results
         check_mode: yes


**Result:**

ok: [localhost] => {
    "changed": false,
    "check_mode": true,
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "api_profile": "latest",
            "append_tags": true,
            "auth_source": null,
            "cert_validation_mode": null,
            "client_id": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "cloud_environment": "AzureCloud",
            "location": "eastus2",
            "log_mode": null,
            "log_path": null,
            "name": "ddos",
            "password": null,
            "profile": null,
            "resource_group": "rg",
            "secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "state": "present",
            "subscription_id": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
            "tags": null,
            "tenant": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER"
        }
    },
    "state": {
        "additional_properties": null,
        "etag": "W/\"\"",
        "id": "/subscriptions/XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX/resourceGroups/rg/providers/Microsoft.Network/ddosProtectionPlans/ddos",
        "location": "eastus2",
        "name": "ddos",
        "provisioning_state": "Succeeded",
        "resource_guid": null,
        "tags": {
            "a": "c"
        },
        "type": "Microsoft.Network/ddosProtectionPlans",
        "virtual_networks": null
    }
}
META: ran handlers
META: ran handlers

PLAY RECAP *************************************************************************************************************************************************************************************************
localhost                  : ok=2    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

Create (Idempotent):

**Playbook**

---
    - hosts: localhost
      connection: local
      tasks:   
       - name: Create DDoS protection plan(Idempotent)
         azure.azcollection.azure_rm_ddosprotectionplan:
           client_id: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           resource_group: rg
           secret: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           subscription_id: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           tenant: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           location: eastus2
           name: ddos
         register: results

**Result:**
ok: [localhost] => {
    "changed": false,
    "check_mode": false,
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "api_profile": "latest",
            "append_tags": true,
            "auth_source": null,
            "cert_validation_mode": null,
            "client_id": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "cloud_environment": "AzureCloud",
            "location": "eastus2",
            "log_mode": null,
            "log_path": null,
            "name": "ddos",
            "password": null,
            "profile": null,
            "resource_group": "rg",
            "secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "state": "present",
            "subscription_id": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
            "tags": null,
            "tenant": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER"
        }
    },
    "state": {
        "additional_properties": null,
        "etag": "W/\"\"",
        "id": "/subscriptions/XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX/resourceGroups/rg/providers/Microsoft.Network/ddosProtectionPlans/ddos",
        "location": "eastus2",
        "name": "ddos",
        "provisioning_state": "Succeeded",
        "resource_guid": null,
        "tags": {},
        "type": "Microsoft.Network/ddosProtectionPlans",
        "virtual_networks": null
    }
}
META: ran handlers
META: ran handlers

PLAY RECAP *************************************************************************************************************************************************************************************************
localhost                  : ok=2    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

Update:

**Playbook:**
---
    - hosts: localhost
      connection: local
      tasks:   
       - name: Updates DDoS protection plan 
         azure.azcollection.azure_rm_ddosprotectionplan:
           client_id: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           resource_group: rg
           secret: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           subscription_id: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           tenant: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           location: eastus2
           name: ddos
           tags:
            a: c
         register: results


**Result:**

changed: [localhost] => {
    "changed": true,
    "check_mode": false,
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "api_profile": "latest",
            "append_tags": true,
            "auth_source": null,
            "cert_validation_mode": null,
            "client_id": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "cloud_environment": "AzureCloud",
            "location": "eastus2",
            "log_mode": null,
            "log_path": null,
            "name": "ddos",
            "password": null,
            "profile": null,
            "resource_group": "rg",
            "secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "state": "present",
            "subscription_id": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
            "tags": {
                "a": "c"
            },
            "tenant": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER"
        }
    },
    "state": {
        "additional_properties": null,
        "etag": "W/\"\"",
        "id": "/subscriptions/XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX/resourceGroups/rg/providers/Microsoft.Network/ddosProtectionPlans/ddos",
        "location": "eastus2",
        "name": "ddos",
        "provisioning_state": "Succeeded",
        "resource_guid": null,
        "tags": {
            "a": "c"
        },
        "type": "Microsoft.Network/ddosProtectionPlans",
        "virtual_networks": null
    }
}
META: ran handlers
META: ran handlers

PLAY RECAP *************************************************************************************************************************************************************************************************
localhost                  : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

Delete (Check_Mode):

**Playbook**
---
    - hosts: localhost
      connection: local
      tasks:
       - name: Delete DDoS Protection Plan (Check Mode)
         azure.azcollection.azure_rm_ddosprotectionplan:
           client_id: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           secret: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           subscription_id: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           tenant: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           resource_group: rg
           name:  ddos
           state: absent
           location: eastus2
         check_mode: yes


**Result:**
changed: [localhost] => {
    "changed": true,
    "check_mode": true,
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "api_profile": "latest",
            "append_tags": true,
            "auth_source": null,
            "cert_validation_mode": null,
            "client_id": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "cloud_environment": "AzureCloud",
            "location": "eastus2",
            "log_mode": null,
            "log_path": null,
            "name": "ddos",
            "password": null,
            "profile": null,
            "resource_group": "rg",
            "secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "state": "absent",
            "subscription_id": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
            "tags": null,
            "tenant": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER"
        }
    },
    "state": {
        "additional_properties": null,
        "etag": "W/\"\"",
        "id": "/subscriptions/XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX/resourceGroups/rg/providers/Microsoft.Network/ddosProtectionPlans/ddos",
        "location": "eastus2",
        "name": "ddos",
        "provisioning_state": "Succeeded",
        "resource_guid": null,
        "tags": null,
        "type": "Microsoft.Network/ddosProtectionPlans",
        "virtual_networks": null
    }
}
META: ran handlers
META: ran handlers

PLAY RECAP *************************************************************************************************************************************************************************************************
localhost                  : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

Delete

**Playbook**
---
    - hosts: localhost
      connection: local
      tasks:
       - name: Delete DDoS Protection Plan
         azure.azcollection.azure_rm_ddosprotectionplan:
           client_id: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           secret: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           subscription_id: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           tenant: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           resource_group: rg
           name:  ddos
           state: absent
           location: eastus2

**Result:**
changed: [localhost] => {
    "changed": true,
    "check_mode": false,
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "api_profile": "latest",
            "append_tags": true,
            "auth_source": null,
            "cert_validation_mode": null,
            "client_id": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "cloud_environment": "AzureCloud",
            "location": "eastus2",
            "log_mode": null,
            "log_path": null,
            "name": "ddos",
            "password": null,
            "profile": null,
            "resource_group": "rg",
            "secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "state": "absent",
            "subscription_id": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
            "tags": null,
            "tenant": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER"
        }
    },
    "state": {
        "additional_properties": null,
        "etag": "W/\"\"",
        "id": "/subscriptions/XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX/resourceGroups/rg/providers/Microsoft.Network/ddosProtectionPlans/ddos",
        "location": "eastus2",
        "name": "ddos",
        "provisioning_state": "Succeeded",
        "resource_guid": null,
        "status": "Deleted",
        "tags": null,
        "type": "Microsoft.Network/ddosProtectionPlans",
        "virtual_networks": null
    }
}
META: ran handlers
META: ran handlers

PLAY RECAP *************************************************************************************************************************************************************************************************
localhost                  : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

Get by name:

**Playbook**
---
    - hosts: localhost
      connection: local
      tasks:
       - name: Retrieve DDoS Protection Plan
         azure.azcollection.azure_rm_ddosprotectionplan_info:
           resource_group: rg
           client_id: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           resource_group: rg
           secret: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           subscription_id: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           tenant: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           name: ddos
         register: results

**Result:**
ok: [localhost] => {
    "changed": false,
    "ddosprotectionplan": [
        {
            "additional_properties": null,
            "etag": "W/\"\"",
            "id": "/subscriptions/XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX/resourceGroups/rg/providers/Microsoft.Network/ddosProtectionPlans/ddos",
            "location": "eastus2",
            "name": "ddos",
            "provisioning_state": "Succeeded",
            "resource_guid": null,
            "tags": {
                "a": "c"
            },
            "type": "Microsoft.Network/ddosProtectionPlans",
            "virtual_networks": null
        }
    ],
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "api_profile": "latest",
            "auth_source": null,
            "cert_validation_mode": null,
            "client_id": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "cloud_environment": "AzureCloud",
            "name": "ddos",
            "password": null,
            "profile": null,
            "resource_group": "rg",
            "secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "subscription_id": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
            "tenant": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER"
        }
    }
}
META: ran handlers
META: ran handlers

PLAY RECAP *************************************************************************************************************************************************************************************************
localhost                  : ok=2    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

Get by resource group:

**Playbook:**
---
    - hosts: localhost
      connection: local
      tasks:
       - name: Retrieve DDoS Protection Plan (By Resource Group)
         azure.azcollection.azure_rm_ddosprotectionplan_info:
           resource_group: rg
           client_id: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           resource_group: rg
           secret: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           subscription_id: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           tenant: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
         register: results

**Result:**
ok: [localhost] => {
    "changed": false,
    "ddosprotectionplan": [
        {
            "additional_properties": null,
            "etag": "W/\"\"",
            "id": "/subscriptions/XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX/resourceGroups/rg/providers/Microsoft.Network/ddosProtectionPlans/ddos",
            "location": "eastus2",
            "name": "ddos",
            "provisioning_state": "Succeeded",
            "resource_guid": null,
            "tags": {
                "a": "c"
            },
            "type": "Microsoft.Network/ddosProtectionPlans",
            "virtual_networks": null
        }
    ],
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "api_profile": "latest",
            "auth_source": null,
            "cert_validation_mode": null,
            "client_id": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "cloud_environment": "AzureCloud",
            "name": null,
            "password": null,
            "profile": null,
            "resource_group": "rg",
            "secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "subscription_id": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
            "tenant": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER"
        }
    }
}
META: ran handlers
META: ran handlers

PLAY RECAP *************************************************************************************************************************************************************************************************
localhost                  : ok=2    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

Get by subscription:

**Playbook:**
---
    - hosts: localhost
      connection: local
      tasks:
       - name: Retrieve DDoS Protection Plan (By Subscription)
         azure.azcollection.azure_rm_ddosprotectionplan_info:
           client_id: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           secret: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           subscription_id: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
           tenant: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
         register: results

**Result:**
ok: [localhost] => {
    "changed": false,
    "ddosprotectionplan": [
        {
            "additional_properties": null,
            "etag": "W/\"\"",
            "id": "/subscriptions/XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX/resourceGroups/rg/providers/Microsoft.Network/ddosProtectionPlans/ddos",
            "location": "eastus2",
            "name": "ddos",
            "provisioning_state": "Succeeded",
            "resource_guid": null,
            "tags": {
                "a": "c"
            },
            "type": "Microsoft.Network/ddosProtectionPlans",
            "virtual_networks": null
        }
    ],
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "api_profile": "latest",
            "auth_source": null,
            "cert_validation_mode": null,
            "client_id": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "cloud_environment": "AzureCloud",
            "name": null,
            "password": null,
            "profile": null,
            "resource_group": null,
            "secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "subscription_id": "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX",
            "tenant": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER"
        }
    }
}
META: ran handlers
META: ran handlers

PLAY RECAP *************************************************************************************************************************************************************************************************
localhost                  : ok=2    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

…ections#524)

…ollections#525)

* class are worngly named. fixed. * fixing sanity errors.

Fred-sun · 2021-05-12T07:37:06Z

@ikarldasan Please add following line to ignore2.11.txt, 2.9.txt, 2.10.txt and 2.12.txt. Thank you very much!

plugins/modules/azure_rm_ddosprotectionplan_info.py validate-modules:required_if-requirements-unknown
plugins/modules/azure_rm_ddosprotectionplan_info.py validate-modules:required_if-unknown-key

Co-authored-by: Fred-sun <[email protected]>

…in.yml Co-authored-by: Fred-sun <[email protected]>

ikarldasan · 2021-05-28T10:24:04Z

@Fred-sun have addressed the changes suggested.
Thank you

Fred-sun · 2021-05-28T14:25:41Z

@ikarldasan Please help to delete all ignores on ignore2.11.txt, ignore2.9.txt, ignore2.10.txt and ignore2.12.txt that you add. It has been fixed by #540!

Fred-sun

@ikarldasan One last update requirement, Thank you very much!

plugins/modules/azure_rm_ddosprotectionplan.py

plugins/modules/azure_rm_ddosprotectionplan_info.py

Co-authored-by: Fred-sun <[email protected]>

ikarldasan · 2021-06-19T08:34:53Z

@ikarldasan One last update requirement, Thank you very much!

@Fred-sun Have updated the changes suggested. Thank you

ikarldasan · 2021-06-30T06:28:35Z

@ikarldasan One last update requirement, Thank you very much!

@Fred-sun Do we need any more enhancements? Can we merge this? Thank you

Fred-sun · 2021-08-02T05:53:23Z

@ikarldasan One last update requirement, Thank you very much!

@Fred-sun Do we need any more enhancements? Can we merge this? Thank you

@ikarldasan I will move forward with the merger as soon as possible. Thank you very much!

* initial commit * add ddos protection plan operations * enhance create flow * enhance operations * enhance get and delete operations * address sanity checks * add integration tests * add log parameters and aliases * rename module for consistency * update pr-pipeline for consistency * fixing update account_enabled bug in azure_rm_aduser.py (ansible-collections#524) * fixing ad related auth issue when using service pricinpal. (ansible-collections#525) * change class name of azure_rm_aduser (ansible-collections#526) * class are worngly named. fixed. * fixing sanity errors. * updating ignore text * Update plugins/modules/azure_rm_ddosprotectionplan.py Co-authored-by: Fred-sun <[email protected]> * Update plugins/modules/azure_rm_ddosprotectionplan.py Co-authored-by: Fred-sun <[email protected]> * Update plugins/modules/azure_rm_ddosprotectionplan.py Co-authored-by: Fred-sun <[email protected]> * Update tests/integration/targets/azure_rm_ddosprotectionplan/tasks/main.yml Co-authored-by: Fred-sun <[email protected]> * Update tests/integration/targets/azure_rm_ddosprotectionplan/tasks/main.yml Co-authored-by: Fred-sun <[email protected]> * Update main.yml * delete ignores * remove ignores * Update plugins/modules/azure_rm_ddosprotectionplan.py Co-authored-by: Fred-sun <[email protected]> * Update plugins/modules/azure_rm_ddosprotectionplan_info.py Co-authored-by: Fred-sun <[email protected]> Co-authored-by: haiyuan_zhang <[email protected]> Co-authored-by: Fred-sun <[email protected]>

ikarldasan added 8 commits April 14, 2021 13:49

initial commit

9f3458e

add ddos protection plan operations

07788ac

enhance create flow

fd71f2b

enhance operations

9f5da54

enhance get and delete operations

1088567

address sanity checks

5d2a295

add integration tests

01de919

Merge branch 'dev' into dev

5847ff5

Fred-sun reviewed Apr 19, 2021

View reviewed changes

Fred-sun added medium_priority Medium priority new_module_pr Add new modules work in In trying to solve, or in working with contributors labels Apr 19, 2021

ikarldasan added 3 commits April 19, 2021 16:00

add log parameters and aliases

7d799ff

rename module for consistency

8106f40

update pr-pipeline for consistency

1ef7654

ikarldasan and others added 4 commits April 22, 2021 10:53

Merge branch 'dev' into dev

4b66573

fixing update account_enabled bug in azure_rm_aduser.py (ansible-coll…

c3e6d59

…ections#524)

fixing ad related auth issue when using service pricinpal. (ansible-c…

6fdfefe

…ollections#525)

change class name of azure_rm_aduser (ansible-collections#526)

24b08f7

* class are worngly named. fixed. * fixing sanity errors.

Merge branch 'dev' into dev

3ae9aa0

haiyuazhang force-pushed the dev branch 2 times, most recently from 2281f46 to 8dfc8ed Compare May 12, 2021 11:26

haiyuazhang changed the title ~~New Module [DDoS Protection Plan]~~ New module: azure_rm_ddosprotectionplan May 17, 2021

ikarldasan added 3 commits May 17, 2021 20:20

Merge branch 'dev' into dev

5d322ed

updating ignore text

912b074

Merge branch 'dev' of github.com:ikarldasan/azure into dev

ddc269e

ikarldasan and others added 2 commits May 28, 2021 15:29

Merge branch 'dev' into dev

6dffe54

Update plugins/modules/azure_rm_ddosprotectionplan.py

22553b1

Co-authored-by: Fred-sun <[email protected]>

ikarldasan dismissed Ryujinx01’s stale review via 22553b1 May 28, 2021 10:00

ikarldasan and others added 6 commits May 28, 2021 15:31

Update plugins/modules/azure_rm_ddosprotectionplan.py

1b5cacc

Co-authored-by: Fred-sun <[email protected]>

Update plugins/modules/azure_rm_ddosprotectionplan.py

6a2c4fe

Co-authored-by: Fred-sun <[email protected]>

Update tests/integration/targets/azure_rm_ddosprotectionplan/tasks/ma…

f5e43e0

…in.yml Co-authored-by: Fred-sun <[email protected]>

Update tests/integration/targets/azure_rm_ddosprotectionplan/tasks/ma…

76199ff

…in.yml Co-authored-by: Fred-sun <[email protected]>

Update main.yml

b8e6bc1

delete ignores

329623c

remove ignores

75eb236

Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels May 28, 2021

Merge branch 'dev' into dev

3f3d3d5

Fred-sun added work in In trying to solve, or in working with contributors and removed ready_for_review The PR has been modified and can be reviewed and merged labels Jun 16, 2021

Fred-sun reviewed Jun 16, 2021

View reviewed changes

plugins/modules/azure_rm_ddosprotectionplan.py Outdated Show resolved Hide resolved

plugins/modules/azure_rm_ddosprotectionplan_info.py Show resolved Hide resolved

ikarldasan and others added 3 commits June 19, 2021 14:00

Update plugins/modules/azure_rm_ddosprotectionplan.py

f0b482e

Co-authored-by: Fred-sun <[email protected]>

Update plugins/modules/azure_rm_ddosprotectionplan_info.py

13128f9

Co-authored-by: Fred-sun <[email protected]>

Merge branch 'dev' into dev

b136325

Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Jun 21, 2021

Merge branch 'dev' into dev

480e271

Merge branch 'dev' into dev

e4bdc81

xuzhang3 merged commit 069c6bb into ansible-collections:dev Aug 6, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New module: azure_rm_ddosprotectionplan #493

New module: azure_rm_ddosprotectionplan #493

ikarldasan commented Apr 16, 2021

Fred-sun commented Apr 19, 2021

Fred-sun left a comment

Fred-sun Apr 19, 2021

Fred-sun Apr 19, 2021

ikarldasan commented Apr 20, 2021

ikarldasan commented Apr 20, 2021 •

edited

Loading

Fred-sun commented May 12, 2021

ikarldasan commented May 28, 2021

Fred-sun commented May 28, 2021

Fred-sun left a comment

ikarldasan commented Jun 19, 2021

ikarldasan commented Jun 30, 2021

Fred-sun commented Aug 2, 2021

	- azure.azcollection.azure
	- azure.azcollection.azure
	- azure.azcollection.azure_tags

New module: azure_rm_ddosprotectionplan #493

New module: azure_rm_ddosprotectionplan #493

Conversation

ikarldasan commented Apr 16, 2021

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

Fred-sun commented Apr 19, 2021

Fred-sun left a comment

Choose a reason for hiding this comment

Fred-sun Apr 19, 2021

Choose a reason for hiding this comment

Fred-sun Apr 19, 2021

Choose a reason for hiding this comment

ikarldasan commented Apr 20, 2021

ikarldasan commented Apr 20, 2021 • edited Loading

Fred-sun commented May 12, 2021

ikarldasan commented May 28, 2021

Fred-sun commented May 28, 2021

Fred-sun left a comment

Choose a reason for hiding this comment

ikarldasan commented Jun 19, 2021

ikarldasan commented Jun 30, 2021

Fred-sun commented Aug 2, 2021

ikarldasan commented Apr 20, 2021 •

edited

Loading