New module: azure_rm_expressroute #484

praveenghuge · 2021-04-08T15:12:14Z

SUMMARY
This module introduces a wide variety of configurations for creating an express route on Azure.

Create Express Route on Azure.
Update Express Route on Azure.
Delete Express Route on Azure.
Get Express Route on Azure.
List Express Route in Azure Resource Group.

Fixes #475

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

azure_rm_expressroute

Additional Support:
for express route peering support we need to create resource in ansible https://docs.microsoft.com/en-us/azure/expressroute/expressroute-introduction
created issue #483

ADDITIONAL INFORMATION
This module allows user to create/update or delete the express route. It also provides all the parameters given by https://docs.microsoft.com/en-us/azure/expressroute/expressroute-introduction
More information:

  azure_rm_expressroute:
    location: eastus
    name: expressroute123
    resource_group: resourcegroup12
    allow_classic_operations: true
    global_reach_enabled: false
    tags:
      a: b
    authorizations:
      - name: authorization_test
    service_provider_properties:
      service_provider_name: Aryaka Networks
      peering_location: Seattle
      bandwidth_in_mbps: '200'
    sku:
      tier: premium
      family: metereddata```

Fred-sun · 2021-04-09T00:55:48Z

@praveenghuge Thank for your contribute! I will review and push for merge!

praveenghuge · 2021-04-14T14:47:44Z

@Fred-sun can you please review

Fred-sun

@Fred-sun can you please review

@praveenghuge Thanks for your contribution! I working in this!

plugins/modules/azure_rm_expressroute.py

Fred-sun

@praveenghuge Would you please share the result of you execute the playbook "tests/integration/targets/azure_rm_expressroute/tasks/main.yml"? It will helpful to push merge this PR! Thank you very much!

plugins/modules/azure_rm_expressroute.py

tests/integration/targets/azure_rm_expressroute/tasks/main.yml

plugins/modules/azure_rm_expressroute_info.py

tests/integration/targets/azure_rm_expressroute/tasks/main.yml

tests/integration/targets/azure_rm_expressroute/aliases

praveenghuge · 2021-04-20T03:16:45Z

playbook

---
 - hosts: localhost
   connection: local
   tasks:

    - name: Create Express route (check mode)
      azure.azcollection.azure_rm_expressroute:

        subscription_id: XXXXX
        tenant: XXXXX
        client_id: XXXX
        secret: XXXX
        resource_group: test
        name: test2
        location: eastus
        state: present
        allow_classic_operations: true
        global_reach_enabled: false
        tags:
                a: b
        authorizations:
                - name: authorization_test
        service_provider_properties:
                service_provider_name: Aryaka Networks
                peering_location: Seattle
                bandwidth_in_mbps: '200'
        sku:
                tier: premium
                family: metereddata
      check_mode: yes

output

changed: [localhost] => {
    "changed": true,
    "check_mode": true,
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "allow_classic_operations": true,
            "api_profile": "latest",
            "append_tags": true,
            "auth_source": "auto",
            "authorizations": [
                {
                    "name": "authorization_test"
                }
            ],
            "cert_validation_mode": null,
            "client_id": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "cloud_environment": "AzureCloud",
            "global_reach_enabled": false,
            "location": "eastus",
            "name": "test2",
            "password": null,
            "profile": null,
            "resource_group": "test-praveen",
            "secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "service_provider_properties": {
                "bandwidth_in_mbps": "200",
                "peering_location": "Seattle",
                "service_provider_name": "Aryaka Networks"
            },
            "sku": {
                "family": "metereddata",
                "tier": "premium"
            },
            "state": "present",
            "subscription_id": "XXXXX",
            "tags": {
                "a": "b"
            },
            "tenant": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER"
        }
    },
    "state": {}
}
META: ran handlers
META: ran handlers

PLAY RECAP ***************************************************************************************
localhost                  : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

praveenghuge · 2021-04-20T03:19:05Z

playbook

---
 - hosts: localhost
   connection: local
   tasks:

    - name: Create Express route
      azure.azcollection.azure_rm_expressroute:

        subscription_id: XXXXX
        tenant: XXXXX
        client_id: XXXX
        secret: XXXX
        resource_group: test
        name: test2
        location: eastus
        state: present
        allow_classic_operations: true
        global_reach_enabled: false
        tags:
                a: b
        authorizations:
                - name: authorization_test
        service_provider_properties:
                service_provider_name: Aryaka Networks
                peering_location: Seattle
                bandwidth_in_mbps: '200'
        sku:
                tier: premium
                family: metereddata

output

changed: [localhost] => {
    "changed": true,
    "check_mode": false,
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "allow_classic_operations": true,
            "api_profile": "latest",
            "append_tags": true,
            "auth_source": "auto",
            "authorizations": [
                {
                    "name": "authorization_test"
                }
            ],
            "cert_validation_mode": null,
            "client_id": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "cloud_environment": "AzureCloud",
            "global_reach_enabled": false,
            "location": "eastus",
            "name": "test2",
            "password": null,
            "profile": null,
            "resource_group": "test-praveen",
            "secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "service_provider_properties": {
                "bandwidth_in_mbps": "200",
                "peering_location": "Seattle",
                "service_provider_name": "Aryaka Networks"
            },
            "sku": {
                "family": "metereddata",
                "name": "premium_metereddata",
                "tier": "premium"
            },
            "state": "present",
            "subscription_id": "XXXX",
            "tags": {
                "a": "b"
            },
            "tenant": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER"
        }
    },
    "state": {
        "additional_properties": {},
        "allow_classic_operations": true,
        "authorizations": [
            {
                "authorization_key": "bbdb6919-ac1a-43a7-ab39-8bfa955ef23f",
                "authorization_use_status": "Available",
                "etag": "W/\"4a3ff51b-12cc-4972-9313-24421edbc855\"",
                "id": "/subscriptions/XxXXX/resourceGroups/test-praveen/providers/Microsoft.Network/expressRouteCircuits/test2/authorizations/authorization_test",
                "name": "authorization_test",
                "provisioning_state": "Succeeded",
                "type": "Microsoft.Network/expressRouteCircuits/authorizations"
            }
        ],
        "bandwidth_in_gbps": null,
        "circuit_provisioning_state": "Enabled",
        "express_route_port": null,
        "gateway_manager_etag": "",
        "global_reach_enabled": false,
        "id": "/subscriptions/XxxX1/resourceGroups/test-praveen/providers/Microsoft.Network/expressRouteCircuits/test2",
        "location": "eastus",
        "name": "test2",
        "peerings": [],
        "provisioning_state": "Succeeded",
        "service_key": "b9e910e0-8475-43c0-b16b-f317fc6ad427",
        "service_provider_notes": null,
        "service_provider_provisioning_state": "NotProvisioned",
        "stag": 24,
        "tags": {
            "a": "b"
        },
        "type": "Microsoft.Network/expressRouteCircuits"
    }
}
META: ran handlers
META: ran handlers

PLAY RECAP ***************************************************************************************
localhost                  : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

praveenghuge · 2021-04-20T03:20:11Z

playbook

---
 - hosts: localhost
   connection: local
   tasks:

    - name: Create Express route (idempotent)
      azure.azcollection.azure_rm_expressroute:

        subscription_id: XXXXX
        tenant: XXXXX
        client_id: XXXX
        secret: XXXX
        resource_group: test
        name: test2
        location: eastus
        state: present
        allow_classic_operations: true
        global_reach_enabled: false
        tags:
                a: b
        authorizations:
                - name: authorization_test
        service_provider_properties:
                service_provider_name: Aryaka Networks
                peering_location: Seattle
                bandwidth_in_mbps: '200'
        sku:
                tier: premium
                family: metereddata

output

ok: [localhost] => {
    "changed": false,
    "check_mode": false,
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "allow_classic_operations": true,
            "api_profile": "latest",
            "append_tags": true,
            "auth_source": "auto",
            "authorizations": [
                {
                    "name": "authorization_test"
                }
            ],
            "cert_validation_mode": null,
            "client_id": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "cloud_environment": "AzureCloud",
            "global_reach_enabled": false,
            "location": "eastus",
            "name": "test2",
            "password": null,
            "profile": null,
            "resource_group": "test-praveen",
            "secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "service_provider_properties": {
                "bandwidth_in_mbps": "200",
                "peering_location": "Seattle",
                "service_provider_name": "Aryaka Networks"
            },
            "sku": {
                "family": "metereddata",
                "tier": "premium"
            },
            "state": "present",
            "subscription_id": "XXXX",
            "tags": {
                "a": "b"
            },
            "tenant": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER"
        }
    },
    "state": {
        "additional_properties": {},
        "allow_classic_operations": true,
        "authorizations": [
            {
                "authorization_key": "bbdb6919-ac1a-43a7-ab39-8bfa955ef23f",
                "authorization_use_status": "Available",
                "etag": "W/\"4a3ff51b-12cc-4972-9313-24421edbc855\"",
                "id": "/subscriptions/XXXX/resourceGroups/test-praveen/providers/Microsoft.Network/expressRouteCircuits/test2/authorizations/authorization_test",
                "name": "authorization_test",
                "provisioning_state": "Succeeded",
                "type": "Microsoft.Network/expressRouteCircuits/authorizations"
            }
        ],
        "bandwidth_in_gbps": null,
        "circuit_provisioning_state": "Enabled",
        "express_route_port": null,
        "gateway_manager_etag": "",
        "global_reach_enabled": false,
        "id": "/subscriptions/XXXX/resourceGroups/test-praveen/providers/Microsoft.Network/expressRouteCircuits/test2",
        "location": "eastus",
        "name": "test2",
        "peerings": [],
        "provisioning_state": "Succeeded",
        "service_key": "b9e910e0-8475-43c0-b16b-f317fc6ad427",
        "service_provider_notes": null,
        "service_provider_provisioning_state": "NotProvisioned",
        "stag": 24,
        "tags": {
            "a": "b"
        },
        "type": "Microsoft.Network/expressRouteCircuits"
    }
}
META: ran handlers
META: ran handlers

PLAY RECAP ***************************************************************************************
localhost                  : ok=2    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

praveenghuge · 2021-04-20T03:22:23Z

playbook

---
 - hosts: localhost
   connection: local
   tasks:

    - name: Update Express route
      azure.azcollection.azure_rm_expressroute:

        subscription_id: XXXXX
        tenant: XXXXX
        client_id: XXXXX
        secret: XXXX
        resource_group: test-praveen
        name: test2
        location: eastus
        state: present
        allow_classic_operations: true
        global_reach_enabled: false
        tags:
                a: b
                test: modified
        authorizations:
                - name: authorization_test
        service_provider_properties:
                service_provider_name: Aryaka Networks
                peering_location: Seattle
                bandwidth_in_mbps: '200'
        sku:
                tier: premium
                family: metereddata

output

changed: [localhost] => {
    "changed": true,
    "check_mode": false,
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "allow_classic_operations": true,
            "api_profile": "latest",
            "append_tags": true,
            "auth_source": "auto",
            "authorizations": [
                {
                    "name": "authorization_test"
                }
            ],
            "cert_validation_mode": null,
            "client_id": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "cloud_environment": "AzureCloud",
            "global_reach_enabled": false,
            "location": "eastus",
            "name": "test2",
            "password": null,
            "profile": null,
            "resource_group": "test-praveen",
            "secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "service_provider_properties": {
                "bandwidth_in_mbps": "200",
                "peering_location": "Seattle",
                "service_provider_name": "Aryaka Networks"
            },
            "sku": {
                "family": "metereddata",
                "name": "premium_metereddata",
                "tier": "premium"
            },
            "state": "present",
            "subscription_id": "XXXX",
            "tags": {
                "a": "b",
                "test": "modified"
            },
            "tenant": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER"
        }
    },
    "state": {
        "additional_properties": {},
        "allow_classic_operations": true,
        "authorizations": [
            {
                "authorization_key": "bbdb6919-ac1a-43a7-ab39-8bfa955ef23f",
                "authorization_use_status": "Available",
                "etag": "W/\"4590b630-dc31-4885-abb8-551de8c0466e\"",
                "id": "/subscriptions/XxXXX/resourceGroups/test-praveen/providers/Microsoft.Network/expressRouteCircuits/test2/authorizations/authorization_test",
                "name": "authorization_test",
                "provisioning_state": "Succeeded",
                "type": "Microsoft.Network/expressRouteCircuits/authorizations"
            }
        ],
        "bandwidth_in_gbps": null,
        "circuit_provisioning_state": "Enabled",
        "express_route_port": null,
        "gateway_manager_etag": "",
        "global_reach_enabled": false,
        "id": "/subscriptions/XXXXX/resourceGroups/test-praveen/providers/Microsoft.Network/expressRouteCircuits/test2",
        "location": "eastus",
        "name": "test2",
        "peerings": [],
        "provisioning_state": "Succeeded",
        "service_key": "b9e910e0-8475-43c0-b16b-f317fc6ad427",
        "service_provider_notes": null,
        "service_provider_provisioning_state": "NotProvisioned",
        "stag": 24,
        "tags": {
            "a": "b",
            "test": "modified"
        },
        "type": "Microsoft.Network/expressRouteCircuits"
    }
}
META: ran handlers
META: ran handlers

PLAY RECAP ***************************************************************************************
localhost                  : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

praveenghuge · 2021-04-20T03:24:30Z

playbook

---
 - hosts: localhost
   connection: local
   tasks:

    - name: Delete Express route
      azure.azcollection.azure_rm_expressroute:
        subscription_id: XXXX
        tenant: XXXX
        client_id: XXXX
        secret: XXXX
        resource_group: test-praveen
        name: test2
        state: absent

output

changed: [localhost] => {
    "changed": true,
    "check_mode": false,
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "allow_classic_operations": null,
            "api_profile": "latest",
            "append_tags": true,
            "auth_source": "auto",
            "authorizations": null,
            "cert_validation_mode": null,
            "client_id": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "cloud_environment": "AzureCloud",
            "global_reach_enabled": null,
            "location": null,
            "name": "test2",
            "password": null,
            "profile": null,
            "resource_group": "test-praveen",
            "secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "service_provider_properties": null,
            "sku": null,
            "state": "absent",
            "subscription_id": "XXXX",
            "tags": null,
            "tenant": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER"
        }
    },
    "state": {
        "additional_properties": {},
        "allow_classic_operations": true,
        "authorizations": [
            {
                "authorization_key": "bbdb6919-ac1a-43a7-ab39-8bfa955ef23f",
                "authorization_use_status": "Available",
                "etag": "W/\"4590b630-dc31-4885-abb8-551de8c0466e\"",
                "id": "/subscriptions/XXXXX/resourceGroups/test-praveen/providers/Microsoft.Network/expressRouteCircuits/test2/authorizations/authorization_test",
                "name": "authorization_test",
                "provisioning_state": "Succeeded",
                "type": "Microsoft.Network/expressRouteCircuits/authorizations"
            }
        ],
        "bandwidth_in_gbps": null,
        "circuit_provisioning_state": "Enabled",
        "express_route_port": null,
        "gateway_manager_etag": "",
        "global_reach_enabled": false,
        "id": "/subscriptions/XXXX/resourceGroups/test-praveen/providers/Microsoft.Network/expressRouteCircuits/test2",
        "location": "eastus",
        "name": "test2",
        "peerings": [],
        "provisioning_state": "Succeeded",
        "service_key": "b9e910e0-8475-43c0-b16b-f317fc6ad427",
        "service_provider_notes": null,
        "service_provider_provisioning_state": "NotProvisioned",
        "stag": 24,
        "status": "Deleted",
        "tags": {
            "a": "b",
            "test": "modified"
        },
        "type": "Microsoft.Network/expressRouteCircuits"
    }
}
META: ran handlers
META: ran handlers

PLAY RECAP ***************************************************************************************
localhost                  : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

praveenghuge · 2021-04-20T03:25:21Z

playbook

---
 - hosts: localhost
   connection: local
   tasks:

    - name: Delete Express route (idempotent)
      azure.azcollection.azure_rm_expressroute:
        subscription_id: XXXX
        tenant: XXXX
        client_id: XXXX
        secret: XXXX
        resource_group: test-praveen
        name: test2
        state: absent

output

ok: [localhost] => {
    "changed": false,
    "check_mode": false,
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "allow_classic_operations": null,
            "api_profile": "latest",
            "append_tags": true,
            "auth_source": "auto",
            "authorizations": null,
            "cert_validation_mode": null,
            "client_id": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "cloud_environment": "AzureCloud",
            "global_reach_enabled": null,
            "location": null,
            "name": "test2",
            "password": null,
            "profile": null,
            "resource_group": "test-praveen",
            "secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "service_provider_properties": null,
            "sku": null,
            "state": "absent",
            "subscription_id": "Xxxx",
            "tags": null,
            "tenant": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER"
        }
    },
    "state": {}
}
META: ran handlers
META: ran handlers

PLAY RECAP ***************************************************************************************
localhost                  : ok=2    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

praveenghuge · 2021-04-20T04:03:39Z

playbook

---
 - hosts: localhost
   connection: local
   tasks:

    - name: Get list of Express route
      azure.azcollection.azure_rm_expressroute_info:

        subscription_id: XxxX
        tenant: XXXXX
        client_id: XXXX
        secret: XXXX
        resource_group: test-praveen

output

ok: [localhost] => {
    "changed": false,
    "expressroute": [
        {
            "additional_properties": {},
            "allow_classic_operations": true,
            "authorizations": [
                {
                    "authorization_key": "af538d56-d627-42bb-9ca1-fd37a3a33d05",
                    "authorization_use_status": "Available",
                    "etag": "W/\"b39a3fa0-4c21-42af-a59c-82886ba8d922\"",
                    "id": "/subscriptions/XXXXX/resourceGroups/test-praveen/providers/Microsoft.Network/expressRouteCircuits/test2/authorizations/authorization_test",
                    "name": "authorization_test",
                    "provisioning_state": "Succeeded",
                    "type": "Microsoft.Network/expressRouteCircuits/authorizations"
                }
            ],
            "bandwidth_in_gbps": null,
            "circuit_provisioning_state": "Enabled",
            "express_route_port": null,
            "gateway_manager_etag": "",
            "global_reach_enabled": false,
            "id": "/subscriptions/XXXX/resourceGroups/test-praveen/providers/Microsoft.Network/expressRouteCircuits/test2",
            "location": "eastus",
            "name": "test2",
            "peerings": [],
            "provisioning_state": "Succeeded",
            "service_key": "4b9caeb9-dc34-4bab-acd2-a10ed3212e13",
            "service_provider_notes": null,
            "service_provider_provisioning_state": "NotProvisioned",
            "stag": 24,
            "tags": {
                "a": "b",
                "test": "modified"
            },
            "type": "Microsoft.Network/expressRouteCircuits"
        }
    ],
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "api_profile": "latest",
            "auth_source": "auto",
            "cert_validation_mode": null,
            "client_id": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "cloud_environment": "AzureCloud",
            "name": null,
            "password": null,
            "profile": null,
            "resource_group": "test-praveen",
            "secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "subscription_id": "XXxX",
            "tenant": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER"
        }
    }
}
META: ran handlers
META: ran handlers

PLAY RECAP ***************************************************************************************
localhost                  : ok=2    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

praveenghuge · 2021-04-20T04:10:32Z

playbook

---
 - hosts: localhost
   connection: local
   tasks:

    - name: Get Express route
      azure.azcollection.azure_rm_expressroute_info:

        subscription_id: XXXX
        tenant: XXXX
        client_id: XXX
        secret: XXX
        resource_group: test-praveen
        name: test2

output

ok: [localhost] => {
    "changed": false,
    "expressroute": [
        {
            "additional_properties": {},
            "allow_classic_operations": true,
            "authorizations": [
                {
                    "authorization_key": "af538d56-d627-42bb-9ca1-fd37a3a33d05",
                    "authorization_use_status": "Available",
                    "etag": "W/\"b39a3fa0-4c21-42af-a59c-82886ba8d922\"",
                    "id": "/subscriptions/Xxxx/resourceGroups/test-praveen/providers/Microsoft.Network/expressRouteCircuits/test2/authorizations/authorization_test",
                    "name": "authorization_test",
                    "provisioning_state": "Succeeded",
                    "type": "Microsoft.Network/expressRouteCircuits/authorizations"
                }
            ],
            "bandwidth_in_gbps": null,
            "circuit_provisioning_state": "Enabled",
            "express_route_port": null,
            "gateway_manager_etag": "",
            "global_reach_enabled": false,
            "id": "/subscriptions/XXXX/resourceGroups/test-praveen/providers/Microsoft.Network/expressRouteCircuits/test2",
            "location": "eastus",
            "name": "test2",
            "peerings": [],
            "provisioning_state": "Succeeded",
            "service_key": "4b9caeb9-dc34-4bab-acd2-a10ed3212e13",
            "service_provider_notes": null,
            "service_provider_provisioning_state": "NotProvisioned",
            "stag": 24,
            "tags": {
                "a": "b",
                "test": "modified"
            },
            "type": "Microsoft.Network/expressRouteCircuits"
        }
    ],
    "invocation": {
        "module_args": {
            "ad_user": null,
            "adfs_authority_url": null,
            "api_profile": "latest",
            "auth_source": "auto",
            "cert_validation_mode": null,
            "client_id": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "cloud_environment": "AzureCloud",
            "name": "test2",
            "password": null,
            "profile": null,
            "resource_group": "test-praveen",
            "secret": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "subscription_id": "xxxx",
            "tenant": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER"
        }
    }
}
META: ran handlers
META: ran handlers

PLAY RECAP ***************************************************************************************
localhost                  : ok=2    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

praveenghuge · 2021-05-25T13:46:03Z

Hi @Fred-sun can you please review the PR. addressed the changes
thank you so much 👍

Fred-sun · 2021-05-26T03:30:26Z

Hi @Fred-sun can you please review the PR. addressed the changes
thank you so much 👍

I'm working on it!

plugins/modules/azure_rm_expressroute_info.py

plugins/modules/azure_rm_expressroute.py

plugins/modules/azure_rm_expressroute_info.py

plugins/modules/azure_rm_expressroute.py

praveenghuge · 2021-05-29T15:36:04Z

Hi @Fred-sun can you please review the PR. addressed the changes
thank you so much 👍

praveenghuge · 2021-06-08T10:19:12Z

@Fred-sun anything pending from our side. Thanks you so much 👍

Fred-sun · 2021-06-08T11:47:55Z

@praveenghuge It is not pending, the new version will be released temporarily, and the PR will be merged after the new version is released. Thank you very much!

praveenghuge · 2021-06-10T12:20:32Z

@Fred-sun updated the latest version
Can you please review
Thank you so much 👍

Fred-sun · 2021-06-10T12:32:55Z

@praveenghuge Greate! Waiting merged!

xuzhang3 · 2021-06-24T05:49:17Z

LGTM

* first commit * fix file * new changes * working create/update/delete/get * change username * minor changes * Fix sanity issues * Improve integration test * remove return * address changes * changes addressed * address changes * address changes * small change * fixing update account_enabled bug in azure_rm_aduser.py (ansible-collections#524) * fixing ad related auth issue when using service pricinpal. (ansible-collections#525) * change class name of azure_rm_aduser (ansible-collections#526) * class are worngly named. fixed. * fixing sanity errors. * address cahnges * new changes * new changes * addrss changes * address changes * address changes * address changes * merge upstream changes * address changes * update version Co-authored-by: root <[email protected]> Co-authored-by: root <[email protected]> Co-authored-by: Praveen Ghuge <[email protected]> Co-authored-by: Praveen Ghuge <[email protected]> Co-authored-by: Karl Dasan <[email protected]> Co-authored-by: haiyuan_zhang <[email protected]>

root and others added 4 commits April 1, 2021 09:00

first commit

6c2d48f

fix file

01df7ac

new changes

460c6af

working create/update/delete/get

3d813ad

praveenghuge changed the title ~~Expressroute~~ New Module [Expressroute] Apr 8, 2021

change username

09c7279

Fred-sun added new_module_pr Add new modules work in In trying to solve, or in working with contributors labels Apr 9, 2021

Praveen Ghuge and others added 6 commits April 9, 2021 08:02

minor changes

3b215da

Fix sanity issues

77441cd

Improve integration test

5be124f

remove return

e83de54

remove return

2e0da02

Merge branch 'dev' into expressroute

adafb4d

praveenghuge added 2 commits April 15, 2021 09:11

Merge branch 'dev' into expressroute

d91c29d

Merge branch 'dev' into expressroute

7f6dc23

Fred-sun reviewed Apr 19, 2021

View reviewed changes

plugins/modules/azure_rm_expressroute.py Outdated Show resolved Hide resolved

pravin94ghuge added 2 commits April 19, 2021 02:15

address changes

20e0182

changes addressed

f0aa8a9

Fred-sun reviewed Apr 19, 2021

View reviewed changes

address changes

1401a72

Fred-sun reviewed May 26, 2021

View reviewed changes

plugins/modules/azure_rm_expressroute_info.py Show resolved Hide resolved

plugins/modules/azure_rm_expressroute.py Outdated Show resolved Hide resolved

plugins/modules/azure_rm_expressroute.py Outdated Show resolved Hide resolved

Fred-sun reviewed May 26, 2021

View reviewed changes

Praveen Ghuge added 2 commits May 28, 2021 23:45

address changes

83b1a31

merge upstream changes

b92ba9b

Fred-sun reviewed May 28, 2021

View reviewed changes

plugins/modules/azure_rm_expressroute.py Outdated Show resolved Hide resolved

merge upstream changes

70e4da8

Fred-sun reviewed May 29, 2021

View reviewed changes

plugins/modules/azure_rm_expressroute_info.py Outdated Show resolved Hide resolved

plugins/modules/azure_rm_expressroute.py Show resolved Hide resolved

address changes

1c64fef

Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels May 30, 2021

Merge branch 'dev' into expressroute

554383b

pravin94ghuge and others added 2 commits June 10, 2021 05:11

update version

1692e20

Merge branch 'dev' into expressroute

1342dc8

Merge branch 'dev' into expressroute

c2cd4c2

xuzhang3 merged commit aead424 into ansible-collections:dev Jun 24, 2021

Fred-sun mentioned this pull request Aug 12, 2021

Add support for expressRouteCircuits Peering #483

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New module: azure_rm_expressroute #484

New module: azure_rm_expressroute #484

praveenghuge commented Apr 8, 2021 •

edited

Loading

Fred-sun commented Apr 9, 2021

praveenghuge commented Apr 14, 2021

Fred-sun left a comment

Fred-sun left a comment

praveenghuge commented Apr 20, 2021 •

edited

Loading

praveenghuge commented Apr 20, 2021 •

edited

Loading

praveenghuge commented Apr 20, 2021 •

edited

Loading

praveenghuge commented Apr 20, 2021 •

edited

Loading

praveenghuge commented Apr 20, 2021 •

edited

Loading

praveenghuge commented Apr 20, 2021 •

edited

Loading

praveenghuge commented Apr 20, 2021 •

edited

Loading

praveenghuge commented Apr 20, 2021

praveenghuge commented May 25, 2021

Fred-sun commented May 26, 2021

praveenghuge commented May 29, 2021

praveenghuge commented Jun 8, 2021

Fred-sun commented Jun 8, 2021

praveenghuge commented Jun 10, 2021

Fred-sun commented Jun 10, 2021 •

edited

Loading

xuzhang3 commented Jun 24, 2021

New module: azure_rm_expressroute #484

New module: azure_rm_expressroute #484

Conversation

praveenghuge commented Apr 8, 2021 • edited Loading

Fred-sun commented Apr 9, 2021

praveenghuge commented Apr 14, 2021

Fred-sun left a comment

Choose a reason for hiding this comment

Fred-sun left a comment

Choose a reason for hiding this comment

praveenghuge commented Apr 20, 2021 • edited Loading

praveenghuge commented Apr 20, 2021 • edited Loading

praveenghuge commented Apr 20, 2021 • edited Loading

praveenghuge commented Apr 20, 2021 • edited Loading

praveenghuge commented Apr 20, 2021 • edited Loading

praveenghuge commented Apr 20, 2021 • edited Loading

praveenghuge commented Apr 20, 2021 • edited Loading

praveenghuge commented Apr 20, 2021

praveenghuge commented May 25, 2021

Fred-sun commented May 26, 2021

praveenghuge commented May 29, 2021

praveenghuge commented Jun 8, 2021

Fred-sun commented Jun 8, 2021

praveenghuge commented Jun 10, 2021

Fred-sun commented Jun 10, 2021 • edited Loading

xuzhang3 commented Jun 24, 2021

praveenghuge commented Apr 8, 2021 •

edited

Loading

praveenghuge commented Apr 20, 2021 •

edited

Loading

praveenghuge commented Apr 20, 2021 •

edited

Loading

praveenghuge commented Apr 20, 2021 •

edited

Loading

praveenghuge commented Apr 20, 2021 •

edited

Loading

praveenghuge commented Apr 20, 2021 •

edited

Loading

praveenghuge commented Apr 20, 2021 •

edited

Loading

praveenghuge commented Apr 20, 2021 •

edited

Loading

Fred-sun commented Jun 10, 2021 •

edited

Loading