Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the adgroup test cases #1426

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

p3ck
Copy link
Collaborator

@p3ck p3ck commented Jan 31, 2024

SUMMARY

The wording for missing entries has changed in the latest version of the code but the test cases were not updated to match.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

tests/integration/targets/azure_rm_adgroup

ADDITIONAL INFORMATION
Before:
TASK [Try to return now deleted group Group Root using object_id] *****************************************************
fatal: [localhost]: FAILED! => {"changed": false, "failed_when_result": true, "msg": "failed to get ad group info \n        APIError\n        Code: 404\n        message: None\n        error: MainError(additional_data={}, code='Request_ResourceNotFound', details=None, inner_error=InnerError(additional_data={'date': DateTime(2024, 1, 29, 21, 33, 56, tzinfo=Timezone('UTC'))}, client_request_id='9e7c6a79-65ea-4878-ab85-21e7281df0a4', date=None, odata_type=None, request_id='72dd7ac5-2a4c-4ed0-a4c9-78324a3cd673'), message=\"Resource 'b5beac8c-9b32-4b5d-9ef4-3daa61eae971' does not exist or one of its queried reference-property objects are not present.\", target=None)\n        "}

After:
TASK [Try to return now deleted group Group Member 1 using object_id] *************************************************
ok: [localhost]

The wording for missing entries has changed in the latest version of the
code but the test cases were not updated to match.
@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged medium_priority Medium priority labels Feb 1, 2024
@xuzhang3 xuzhang3 merged commit f855fed into ansible-collections:dev Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants