Adding tags to the azure_rm_appgateway module. #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fred-sun
added
medium_priority
Fred-sun
reviewed
Jan 19, 2024
|
@jmighion small change request! |
Fred-sun
reviewed
Jan 26, 2024
|
kindly ping! |
Fred-sun
added
ready_for_review
xuzhang3
approved these changes
Feb 1, 2024
|
@jmighion LGTM 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The azure_rm_appgateway module looks like it was intended to use tags because of the
supports_tags=Trueflag for AzureRMModuleBase, but it seems like they were just missed. I'm adding them in so when using this module the tags get set on the resource in Azure. I have confirmed create and update (deleting tags) works. There doesn't seem to be an existing issue for this yet.ISSUE TYPE
COMPONENT NAME
azure_rm_appgateway