Add auth_mode to azure_rm_storageblob #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the parameter `auth_mode` to the `azure_rm_storageblob` module, making it possible to create blobs without using access keys.
ephracis
force-pushed
the
1283-storage-blob-with-login-auth
branch
from
41b231d to
ac33b1b
Compare
Test using auth_mode='login' for storage blobs. This has been tested on a machine with MSI.
|
Fixed sanity tests and adjusted integration tests. Not sure how this will work in your pipeline but I have tried it on a server where we are using Hope that's enough for now. :) |
|
@ephracis Small change request, line 678 contain unexpected spaces around keyword / parameter equals, Please deleted! Thank you very much! |
Fred-sun
reviewed
Nov 6, 2023
Fred-sun
added
enhancement
xuzhang3
approved these changes
Nov 8, 2023
|
@ephracis LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the parameter
auth_modeto theazure_rm_storageblobmodule, making it possible to create blobs without using access keys.SUMMARY
Add the parameter
auth_modeto theazure_rm_storageblobmodule.Fixes #1283, #1255
ISSUE TYPE
COMPONENT NAME
azure_rm_storageblob
ADDITIONAL INFORMATION
This allows customer which has disabled access keys to use the module.