-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow to set boot diagnostics storage account to managed #1206
allow to set boot diagnostics storage account to managed #1206
Conversation
Co-authored-by: Fred-sun <[email protected]>
@Klaas- Wouldn't it be nice to add a parameter to boot_diagnistics, such as' type',
|
I changed the behavior -- there is now an optional argument type: managed - if you set that the storage account will be managed. Anything else will result in the same behavior as before. I would suggest to change the default to managed on the next major release |
@Klaas- Please change the following lines accordingly. azure/plugins/modules/azure_rm_virtualmachine.py Line 1719 in da4b86c
azure/plugins/modules/azure_rm_virtualmachine.py Line 1622 in da4b86c
Update: if self.boot_diagnostics_present and self.boot_diagnostics['enabled'] and self.boot_diagnostics .get('type') != 'managed': |
@Klaas- LGTM 🚢 |
SUMMARY
Allow to use "managed" for boot diagnostic storage accounts, this means no storage account gets created.
https://learn.microsoft.com/en-us/azure/virtual-machines/boot-diagnostics#enable-managed-boot-diagnostics
Fixes #993
ISSUE TYPE
COMPONENT NAME
azure_rm_virtualmachine.py