-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed subscription_id from azure_keyvault_secret lookup when using az cli auth #1175
Conversation
Added Azure CLI support Updated documentation
Removed subscription_id from examples
@msl0 I recommend adding support for "az login" credentials, as there are users using this plugin even through az login! Thanks! |
@Fred-sun support for "az login" is included. |
@msl0 Ok, I'll test it out as soon as possible! Thanks! |
@msl0 There is a conflict in the file you submitted. Can you fix it? |
@Fred-sun fixed and then tested once again |
@Fred-sun did you have a chance to take a look at my PR? |
@msl0 Being tested. Thank you! |
This comment was marked as resolved.
This comment was marked as resolved.
@msl0 Everything else is fine, But there's one sanity test that always has a problem, you can't find the cause. Can you adjust the location of 'import logging'? Avoid this mistake. Please change line 121 below line 118. Thank you!
|
@Fred-sun Thank you! I changed the import order if that's what you meant. But I don't fully understand the problem. I didn't notice anything when testing the change locally so maybe there is some problem with the test |
Added support for Azure CLI authentication without subscription ID in azure_keyvault_secret lookup plugin, fixes #1174