Add unit test showing high CPU utilization when attempting to get /120 subnet #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastien-rosset
force-pushed
the
ipv6_high_cpu
branch
from
cfff801 to
acf52be
Compare
NilashishC
reviewed
Feb 2, 2022
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| minor_changes: | |||
There was a problem hiding this comment.
Suggested change
| minor_changes: | |
| doc_changes: |
|
Unable to freeze job graph: Job network-ee-unit-tests depends on network-ee-build-container-image which was not run. |
sebastien-rosset
force-pushed
the
ipv6_high_cpu
branch
from
89cf854 to
f016252
Compare
|
Unable to freeze job graph: Job network-ee-unit-tests depends on network-ee-build-container-image which was not run. |
|
recheck |
|
Build failed.
|
|
This at the very least needs a rebase, but the changelog update is also correct- no code is changing here outside of tests, so this is at best a |
rohitthakur2590
requested review from
NilashishC
and removed request for
Qalthos and
NilashishC
rohitthakur2590
removed
the
waiting_on_author
|
Closing as above changes has already been added from a different PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Two bugs are exposed by the unit tests, one in
netaddrand one inansible.utils. The"2600:1f1c:1b3:8f00::/56" | ipsubnet(120, 0)unit test causes theipsubnetfilter to attempt to create 18446744073709551616 subnets, this never returns.ISSUE TYPE
COMPONENT NAME
ipsubnet filter
ADDITIONAL INFORMATION