Display warning message for masquerade and icmp-block-inversion #254
Conversation
saito-hideki
changed the title
|
Closing and reopening for CI trigger |
saito-hideki
changed the title
|
Hi @Akasurde @Andersson007 [1] #249 (review) |
|
looking |
There was a problem hiding this comment.
@saito-hideki thanks for the PR!
I would use the module.warn method here rather than warnings that can be missed in the returned json so that users will see them at least in a console / awx logs.
If it sounds sensible, don't rush to change the code. Let's see what @Akasurde thinks on my suggestions.
…block-inversion * This PR is a part of #249 Signed-off-by: Hideki Saito <[email protected]>
saito-hideki
changed the title
saito-hideki
changed the title
|
Hi @Andersson007 |
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| minor_changes: | |||
There was a problem hiding this comment.
I think this is breaking change. What do you think @Andersson007 ?
There was a problem hiding this comment.
@Akasurde i think the warning itself isn't, so i believe that's fine.
If the type change wasn't announced yet, we should add another fragment under major_changes: to announce that the change is coming soon.
There was a problem hiding this comment.
Ok, I think then we can merge this #249 after this PR is merged.
Akasurde
added
the
gate
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
|
@Akasurde @Andersson007 thanks guys! :) |
SUMMARY
Display warning message if the wrong parameter set to
masqueradeoricmp-block-inversionIt is a part of #249. Currently, the variable type of the above two parameters is
str, but will bechangedto bool in the future. As a starting point, this fix displays a warning message if a non-boolean value is specified.ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION