Properly quote Synchronize

[tadeboro]

SUMMARY

The synchronize action plugin and module were a bit sloppy when it came to the command-line parameter quoting and that caused failure on some systems (for example, on Fedora 34).

This commit makes sure any arguments with potentially problematic characters are quoted before being used.

Fixes #242

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

synchronize

[tadeboro]

/cc @sshnaidm

[sshnaidm]

I have a following error on f33:

    "rc": 14
}

MSG:

rsync: [sender] Failed to exec podman exec -i: No such file or directory (2)
rsync error: error in IPC code (code 14) at pipe.c(85) [sender=3.2.3]
rsync: connection unexpectedly closed (0 bytes received so far) [sender]
rsync error: error in IPC code (code 14) at io.c(228) [sender=3.2.3]

[tadeboro]

I have a following error on f33:

    "rc": 14
}

MSG:

rsync: [sender] Failed to exec podman exec -i: No such file or directory (2)
rsync error: error in IPC code (code 14) at pipe.c(85) [sender=3.2.3]
rsync: connection unexpectedly closed (0 bytes received so far) [sender]
rsync error: error in IPC code (code 14) at io.c(228) [sender=3.2.3]

Ugh, this might be "fun" since it looks like that by making f34 happy, I broke f33 (and probably a few systems more). But looking at the output of the task, I see that Ansible executed the following command:

/usr/bin/rsync --delay-updates -F --compress --archive --blocking-io --rsh='podman exec -i' --out-format='<<CHANGED>>%i %n%L' /home/tadej/steampunk/collections/ansible.posix/ansible_collections testpod:/tmp/collections

And by looking at the rsync man page, this should be a valid command. Let me try wake my f33 up and see what command I see there.

[tadeboro]

The new code works for me on my old Fedora 33 and the main branch fails exactly the same on my f33 as it does on f34. So now I am really puzzled about what is going on here. So I guess there is something different between my and @sshnaidm machine. Now we just need to figure out whose machine is messed up and what that mess actually is ;)

[sshnaidm]

On fresh fedora33 and CentOS 8 works fine. LGTM

[Akasurde]

LGTM

[Andersson007]

@saito-hideki this PR got 2 approvals, can we gate this?

[ansible-zuul]

LGTM!